Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wrapGAppsHook for parcellite also add dependencies #32364

Closed
wants to merge 2 commits into from

Conversation

rycee
Copy link
Member

@rycee rycee commented Dec 5, 2017

Motivation for this change

To improve the out-of-box user experience for Parcellite.

CC @gleber

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Also add hicolor icon theme as a dependency. These are needed for
parcellite to find icons.
These allows Parcellite's auto-paste feature to work out of the box.
@rycee rycee changed the title Gwrap/parcellite Use wrapGAppsHook for parcellite also add dependencies Dec 5, 2017
@rycee rycee mentioned this pull request Dec 6, 2017
8 tasks
@gleber
Copy link
Contributor

gleber commented Dec 7, 2017

Looks good to me!

@rycee
Copy link
Member Author

rycee commented Dec 7, 2017

Thanks! Rebased to master in 7908132.

@rycee rycee closed this Dec 7, 2017
@rycee rycee deleted the gwrap/parcellite branch December 26, 2017 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants