Avoid empty author and email #5355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sija
reviewed
Dec 6, 2017
src/compiler/crystal/tools/init.cr
Outdated
| end | ||
|
|
||
| def self.fetch_github_name | ||
| default = "[your-github-name]" | ||
| default = "your-github-name" |
There was a problem hiding this comment.
I'd keep brackets as an easy placeholder designation.
There was a problem hiding this comment.
@Sija Yeah I wanted to keep brackets too, but then it will fail to parse shard.yml
authors:
- [your-name-here] <[your-email-here]>Outputs:
in /home/main/blog/shard.yml: Expected SCALAR but was SEQUENCE_START at line 5, column 5
3.
4. authors:
5. - [your-name-here] <[your-email-here]>
There was a problem hiding this comment.
So just quote it in the ECR file?
RX14
requested changes
Dec 6, 2017
| @@ -44,17 +44,21 @@ module Crystal | |||
| end | |||
|
|
|||
| def self.fetch_author | |||
| return "[your-name-here]" unless system(WHICH_GIT_COMMAND) | |||
There was a problem hiding this comment.
if system(WHICH_GIT COMMAND)
user_name = `git config --get user.name`.strip
user_name = nil if user_name.empty?
end
user_name || "[your-name-here]"
src/compiler/crystal/tools/init.cr
Outdated
| end | ||
|
|
||
| def self.fetch_email | ||
| return "[your-email-here]" unless system(WHICH_GIT_COMMAND) |
RX14
approved these changes
Dec 7, 2017
Sija
reviewed
Dec 7, 2017
src/compiler/crystal/tools/init.cr
Outdated
| github_name = `git config --get github.name`.strip | ||
| github_name = nil if github_name.empty? | ||
| end | ||
| github_name || "your-github-here" |
There was a problem hiding this comment.
your-github-here -> your-github-name
|
@RX14 Can this PR get merged before |
|
@faustinoaq no because 0.24.1 has already been tagged. |
RX14
approved these changes
Dec 15, 2017
asterite
approved these changes
Jan 2, 2018
lukeasrodgers
pushed a commit
to lukeasrodgers/crystal
that referenced
this pull request
Jan 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User may not also have
user.emailanduser.nameconfigured, sofetch_emailandfetch_authorwill return an empty string (instead of"[your-email-here]"or"[your-name-here]").Suggested on amberframework/amber#434 (comment)