mydumper: init at 0.9.3 #32385
Merged
mydumper: init at 0.9.3 #32385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adisbladis
requested changes
Dec 6, 2017
| sha256 = "139v6707sxyslg7n1fii8b1ybdq50hbqhc8zf6p1cr3h2hhl6ns9"; | ||
| }; | ||
|
|
||
| buildInputs = [ cmake glib mariadb.client.dev libressl pcre pkgconfig zlib ]; |
There was a problem hiding this comment.
cmake and pkgconfig should be under nativeBuildInputs instead
|
|
||
| buildInputs = [ cmake glib mariadb.client.dev libressl pcre pkgconfig zlib ]; | ||
|
|
||
| meta = with stdenv.lib; { |
There was a problem hiding this comment.
Are you willing to maintain this package?
If so please add yourself as a maintainer in https://github.com/NixOS/nixpkgs/blob/master/lib/maintainers.nix
Personally I'm very reluctant to merge new packages without a maintainer.
| src = fetchFromGitHub { | ||
| owner = "maxbube"; | ||
| repo = "mydumper"; | ||
| rev = "eef4d8291803e9ba57b4e58458cec3f4f7f0b203"; |
There was a problem hiding this comment.
Please change to rev = "v${version}";.
|
I have rebased and squashed your commits (usually a new package would be one commit, any fixup commits should be squashed). Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)