nixos/gollum: enable emoji and file uploads #32373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
changed the title
Mic92
reviewed
Dec 6, 2017
| @@ -91,6 +103,8 @@ in | |||
| --config ${builtins.toFile "gollum-config.rb" cfg.extraConfig} \ | |||
| --ref ${cfg.branch} \ | |||
| ${optionalString cfg.mathjax "--mathjax"} \ | |||
| ${optionalString cfg.emoji "--emoji"} \ | |||
| ${if cfg.allowUploads != null then "--allow-uploads ${cfg.allowUploads}" else ""} \ | |||
There was a problem hiding this comment.
please use also optionalString here.
Mic92
reviewed
Dec 6, 2017
| @@ -91,6 +103,8 @@ in | |||
| --config ${builtins.toFile "gollum-config.rb" cfg.extraConfig} \ | |||
| --ref ${cfg.branch} \ | |||
| ${optionalString cfg.mathjax "--mathjax"} \ | |||
| ${optionalString cfg.emoji "--emoji"} \ | |||
| ${optionalString cfg.allowUploads "--allow-uploads ${cfg.allowUploads}"} \ | |||
There was a problem hiding this comment.
should be:
- ${optionalString cfg.allowUploads "--allow-uploads ${cfg.allowUploads}"} \
+ ${optionalString (cfg.allowUploads != null) "--allow-uploads ${cfg.allowUploads}"} \null does not evaluate to bool.
|
Excellent! Was already missing that feature. |
maiksensi
pushed a commit
to maiksensi/nixpkgs
that referenced
this pull request
Dec 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)