Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddate: add Darwin as a target #32380

Closed
wants to merge 1 commit into from
Closed

ddate: add Darwin as a target #32380

wants to merge 1 commit into from

Conversation

LambdaP
Copy link
Contributor

@LambdaP LambdaP commented Dec 6, 2017 •
edited

Motivation for this change

The ddate package compiles as is (tested on macos 10.13.1, but it is highly unlikely that it should be very different in older versions). This change allows nix to install it on Darwin.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@LambdaP LambdaP changed the title Add Darwin as a target for ddate ddate: add Darwin as a target Dec 6, 2017
@LambdaP
Copy link
Contributor Author

LambdaP commented Dec 6, 2017

Closing to re-submit following CONTRIBUTING.md.

@LambdaP LambdaP closed this Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LambdaP @Janik-Haag