Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacecraft orientation change during parent body transition #1639

Closed
Damien212 opened this issue Dec 2, 2017 · 6 comments
Closed

Spacecraft orientation change during parent body transition #1639

Damien212 opened this issue Dec 2, 2017 · 6 comments
Labels
Milestone

Comments

@Damien212
Copy link

Damien212 commented Dec 2, 2017

Hi,

I'm experiencing a bug relating to a single part spin stabilized satellite instantaneously changing orientation during a parent body change. This satellite was supposed to escape the Earth and enter a heliocentric orbit.

The craft, when released from its launch vehicle facing Normal/Radial In with reference to the Sun (to keep solar panels aligned) should stay that way when leaving the Earth as parent and entering the Sun as parent. What actually happens is a split second freeze on parent body change and the craft is then pointing Sun Tangent/Prograde. So effectively a 90 degree turn.

I've recorded the bug happening here: https://youtu.be/swtIJAohGX8

KSP Version: 1.2.2
Principia Version: 陈景润
Craft: Raidernick US Probes Pioneer 5
Potential Mod Interaction: Persistent Rotation 1.8.4

@Damien212 Damien212 changed the title Spacecraft Orientation Change During SOI Transition Spacecraft orientation change during SOI transition Dec 2, 2017
@pleroy pleroy added the bug label Dec 2, 2017
@Damien212
Copy link
Author

Damien212 commented Dec 2, 2017

INFO.20171202-222832.1368.txt

I've just reloaded a save just before the parent body transition to save the info file. The timestamps won't match the video though.

@Damien212 Damien212 changed the title Spacecraft orientation change during SOI transition Spacecraft orientation change during parent body transition Dec 3, 2017
@eggrobin
Copy link
Member

eggrobin commented Dec 3, 2017

We know what is happening here: Principia does axial tilt by tilting the universe around the main body, and it does not properly tilt the vessels while doing so.

We want to fix that by handling rotation ourselves eventually (thereby also doing what PersistentRotation does), but this will take time. This is unfortunate for your Pioneers.

@Damien212
Copy link
Author

Ah, that makes sense. I'll bear it in mind for future missions. Thanks.

@pleroy
Copy link
Member

pleroy commented Feb 24, 2020

For the record, the following pull requests were needed to reach the point where this issue could be properly fixed:

#1860, #1861, #1862, #1863, #1884 (reverted), #2200, #2201, #2202, #2203, #2204, #2205, #2206, #2207, #2208, #2209, #2210, #2211, #2212, #2213, #2214, #2215, #2216, #2217, #2218, #2220, #2221, #2223, #2224, #2225, #2232, #2233, #2235, #2236, #2237, #2238, #2241, #2243, #2246, #2250, #2251, #2327, #2330, #2333, #2349, #2350, #2351, #2353, #2354, #2355, #2359, #2362, #2364, #2366, #2367, #2368, #2371, #2377, #2379, #2382, #2384, #2386, #2387, #2388, #2392, #2394, #2396, #2397, #2411, #2414, #2416, #2418, #2420, #2421, #2423, #2426, #2428, #2435, #2438, #2451, #2452, #2459, #2463, #2464, #2465, #2467, #2471, #2473, #2474, #2475, #2477, #2481.

#2375 is also related but it's still under review.

@pleroy pleroy added this to the Frobenius milestone Feb 24, 2020
@Growflavor
Copy link

For the record, the following pull requests were needed

Wow! & Thank you :-)

@pleroy pleroy closed this as completed Mar 20, 2020
@pleroy
Copy link
Member

pleroy commented Mar 21, 2020

And some more: #2483, #2499, #2500.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants