scalafmt: 0.6.8 -> 1.3.0 #32442
Merged
scalafmt: 0.6.8 -> 1.3.0 #32442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markus1189
force-pushed
the
scalafmt-130
branch
from
addb83d
to
7fa5122
Compare
markus1189
force-pushed
the
scalafmt-130
branch
from
7fa5122
to
4bd49e5
Compare
markus1189
force-pushed
the
scalafmt-130
branch
from
4bd49e5
to
45b0061
Compare
|
@volth Wow that would make it A LOT easier. I would be okay with waiting for the coursier merge, given that it avoids having to execute my script. |
markus1189
force-pushed
the
scalafmt-130
branch
from
45b0061
to
55047d2
Compare
|
One disadvantage is that the dependencies will never be shared with other projects right? |
|
Fair enough, I think convenience is more important here |
markus1189
force-pushed
the
scalafmt-130
branch
from
55047d2
to
ac0b461
Compare
markus1189
force-pushed
the
scalafmt-130
branch
from
ac0b461
to
614a6d4
Compare
|
So this is ready for merge I think ;) |
|
It does not build: https://hydra.nixos.org/build/65996166 |
|
Will have a look this evening
…On Dec 14, 2017 16:24, "Orivej Desh" ***@***.***> wrote:
It does not build: https://hydra.nixos.org/build/65996166
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#32442 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAkGz44fgGl_eYEMrf0bxqOmqJiegSAnks5tAT2lgaJpZM4Q6yOj>
.
|
|
I'll fix it. |
orivej
added a commit
to orivej/nixpkgs
that referenced
this pull request
Dec 14, 2017
Do not override phases for the fixupPhase to patching the script interpreter of .coursier-wrapped. Fixes the sandboxed build of scalafmt: NixOS#32442 (comment)
|
Okay then I can also revert back to my script generated build that fetches
all dependencies from maven
On Dec 15, 2017 09:33, "volth" <notifications@github.com> wrote:
I suspect the coursier derivation might need bigger changes in order to be
used in Hydra builds
#25560 <#25560>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#32442 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAkGz7l8Sna87Ha60faoUFLRfSbpV7rWks5tAi7mgaJpZM4Q6yOj>
.
|
|
Okay I thought you mean with bigger changes that there is some problem. If
we can fix coursier that is better.
…On Dec 15, 2017 09:42, "volth" ***@***.***> wrote:
Okay then I can also revert back to my script generated build that fetches
Why?
It would be useful to fix coursier anyway.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#32442 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAkGz1LDxTl5ZFK3SJ1vEp684rnazobtks5tAjDugaJpZM4Q6yOj>
.
|
|
@volth Could you give me a pointer to where I should look for hydra builds etc? |
|
I have pushed 0ea7ad1 to make Hydra try to rebuild scalafmt deps. |
orivej
added a commit
that referenced
this pull request
Dec 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Scalafmt does no longer (already pretty long :D) package a fat-jar, which required a larger change to fetch all
jardependencies via nix, before we could use the newer versions.I finally came around to creating a script that automates the creation of a file
support.nixwhich lists all of them and fetches them usingfetchMavenArtifact: https://gist.github.com/markus1189/e48f8bbaa63b1272d39d74c498116003.With that I updated the the build to version 1.3.0.
Question: I saw that it should be enough to add the
fetchMavenArtifactresults to the buildInputs, but it seems like they never got added to theCLASSPATH(as tested viaecho $CLASSPATHinside the builder). That's why I added them manually in themakeWrapper, but if there is an easier way let me know./cc @olafurpg FYI :)
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)24 Pull Requests (https://24pullrequests.com)