Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.setuptools: make compatible with hasPythonModule #32432

Closed
wants to merge 1 commit into from
Closed

pythonPackages.setuptools: make compatible with hasPythonModule #32432

wants to merge 1 commit into from

Conversation

datakurre
Copy link
Contributor

Motivation for this change

Fixes #32431

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@datakurre datakurre requested a review from FRidh as a code owner December 8, 2017 02:33
@FRidh
Copy link
Member

FRidh commented Dec 8, 2017

Thanks. Pushed 859dc02 to staging.

@FRidh FRidh closed this Dec 8, 2017
@FRidh FRidh added 6.topic: python 0.kind: regression Something that worked before working no longer labels Dec 8, 2017
@adisbladis adisbladis mentioned this pull request Dec 8, 2017
Closed
@FRidh
Copy link
Member

FRidh commented Dec 8, 2017

Reverted in 19b82ec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
0.kind: regression Something that worked before working no longer 6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@datakurre @FRidh