Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromium: 62.0.3202.94 -> 63.0.3239.84 #32433

Merged
merged 1 commit into from Dec 9, 2017
Merged

chromium: 62.0.3202.94 -> 63.0.3239.84 #32433

merged 1 commit into from Dec 9, 2017

Conversation

YorikSar
Copy link
Contributor

@YorikSar YorikSar commented Dec 8, 2017

New stable release with bunch of security fixes and other changes [0]

Also:

  • remove patch for dev already landed upstream
  • remove patches specific to version 62
  • dev is broken again, need to investigate failures

[0] https://chromereleases.googleblog.com/2017/12/stable-channel-update-for-desktop.html

Motivation for this change

Stable release update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@YorikSar
Copy link
Contributor Author

YorikSar commented Dec 8, 2017

@bendlas Can you take a look?

@vcunat
Copy link
Member

vcunat commented Dec 8, 2017

More patches can be removed, I suppose?

trace: WARNING: chromium: stable version 63.0.3239.84 is newer than a patchset bounded at 63. You can safely delete it.

@YorikSar
Copy link
Contributor Author

YorikSar commented Dec 8, 2017

@vcunat Oh, that's not about patches but about other stuff that was there just for version 62, totally forgot about that, will fix.

@YorikSar
chromium: 62.0.3202.94 -> 63.0.3239.84
62ef090 
New stable release with bunch of security fixes and other changes [0]

Also:
* remove patch for dev already landed upstream
* remove patches specific to version 62
* dev is broken again, need to investigate failures

[0] https://chromereleases.googleblog.com/2017/12/stable-channel-update-for-desktop.html
@YorikSar
Copy link
Contributor Author

YorikSar commented Dec 8, 2017

@vcunat I've removed all leftover version checks that are always true now.

@vcunat
Copy link
Member

vcunat commented Dec 8, 2017

Well, that version built OK for me and during a few minutes of usage found no breakage. (Now I'd have to rebuild.)

@bendlas bendlas merged commit 994a614 into NixOS:master Dec 9, 2017
@bendlas
Copy link
Contributor

bendlas commented Dec 9, 2017

Thanks for getting this done and the feedback round, respectively. I'll port it to stable ...

bendlas pushed a commit that referenced this pull request Dec 9, 2017
@YorikSar @bendlas
chromium: 62.0.3202.94 -> 63.0.3239.84
afd3dbf 
New stable release with bunch of security fixes and other changes [0]

Also:
* remove patch for dev already landed upstream
* remove patches specific to version 62
* dev is broken again, need to investigate failures

[0] https://chromereleases.googleblog.com/2017/12/stable-channel-update-for-desktop.html

(cherry picked from commit 994a614)
Signed-off-by: Herwig Hochleitner <herwig@bendlas.net>
ref #32433
@copumpkin
Copy link
Member

dev is broken again, need to investigate failures

Anyone know what's wrong with it?

@YorikSar
Copy link
Contributor Author

@copumpkin Last time it seemed to be that we have snappy library and chromium building with different C++11 ABIs, but I didn't dig further yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@YorikSar @vcunat @bendlas @copumpkin @GrahamcOfBorg