Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memo: init at 0.2 + changed my email address #32179

Merged
merged 2 commits into from Dec 1, 2017
Merged

memo: init at 0.2 + changed my email address #32179

merged 2 commits into from Dec 1, 2017

Conversation

mrVanDalo
Copy link
Contributor

@mrVanDalo mrVanDalo commented Nov 29, 2017 •
edited by zimbatm

Motivation for this change

I want one of my apps in the nixpkgs upstream
I also want to update my email address in the maintainers list ( separate commit of course )

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Nov 29, 2017 •
edited

You have created this pull request from a different branch. Please base your pull request on master and add your commits on top.

@mrVanDalo
Copy link
Contributor Author

@Mic92 Sure, I did like described here. https://nixos.org/nixpkgs/manual/#idm140737317305456 (maybe the documentation is out of date?) it says I should not work in the master branch. (maybe misread that, and thought I should not branch from the master)

zimbatm
zimbatm reviewed Nov 30, 2017
View reviewed changes
lib/maintainers.nix Outdated
@@ -483,7 +483,7 @@
oxij = "Jan Malakhovski <oxij@oxij.org>";
paholg = "Paho Lurie-Gregg <paho@paholg.com>";
pakhfn = "Fedor Pakhomov <pakhfn@gmail.com>";
palo = "Ingolf Wanger <palipalo9@googlemail.com>";
palo = "Ingolf Wanger <nixos@ingolf-wagner.de>";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that you? the key should be your github handle

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, damn. both emails belong to me, but the googlemail.com is my github handle. let me check if I can change that

@mrVanDalo
Copy link
Contributor Author

@zimbatm contact@ingolf-wagner.de is my current github email address.

@zimbatm
Copy link
Member

zimbatm commented Nov 30, 2017

sorry I meant palo should be mrVanDalo so that it maps to your github handle. This lets people more easily @mention you if there are issues with these packages.

@mrVanDalo
Copy link
Contributor Author

@zimbatm done. for this I also had to touch all packages I "maintain".

@zimbatm zimbatm merged commit aa5fa2f into NixOS:master Dec 1, 2017
@zimbatm
Copy link
Member

zimbatm commented Dec 1, 2017

all good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm zimbatm left review comments

@edolstra edolstra Awaiting requested review from edolstra

@edwtjo edwtjo Awaiting requested review from edwtjo

@FRidh FRidh Awaiting requested review from FRidh

@nbp nbp Awaiting requested review from nbp

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mrVanDalo @Mic92 @zimbatm @GrahamcOfBorg