Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apt-dater: init at 1.0.3 #32175

Merged
merged 7 commits into from Oct 26, 2018
Merged

apt-dater: init at 1.0.3 #32175

merged 7 commits into from Oct 26, 2018

Conversation

enko
Copy link
Contributor

@enko enko commented Nov 29, 2017

Motivation for this change

I'm personaly using this nix package all the time and dont want it to get lost if my machine might breaks and I thought others might need this too.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@enko enko changed the title WIP apt-dater: init at 1.0.3 apt-dater: init at 1.0.3 Nov 29, 2017
doCheck = true;

meta = with stdenv.lib; {
homepage = https://www.ibh.de/apt-dater/;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get a 404 for this URL.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is actually on ongoing issue of this project: DE-IBH/apt-dater#123

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will change the url to the github repo for now, till the issue is fixed.


meta = with stdenv.lib; {
homepage = https://www.ibh.de/apt-dater/;
description = "provides an ncurses frontend for managing package updates on a large number of remote hosts using SSH";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO this is a bit long for a description. I'd suggest something like the description on their github: "Terminal-based remote package update manager". You can keep this description inside longDescription.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the descriptions from https://web.archive.org/web/20160811063553/http://www.ibh.de:80/apt-dater/ (the old homepage)

@Mic92
Copy link
Member

Mic92 commented Nov 29, 2017

@GrahamcOfBorg build apt-dater

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

clang-4.0: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [Makefile:459: apt-dater] Error 1
make[2]: Leaving directory '/private/tmp/nix-build-apt-dater-1.0.3.drv-0/apt-dater-1.0.3/src'
make[1]: *** [Makefile:419: all-recursive] Error 1
make[1]: Leaving directory '/private/tmp/nix-build-apt-dater-1.0.3.drv-0/apt-dater-1.0.3'
make: *** [Makefile:358: all] Error 2
builder for '/nix/store/y9p4liqj38431ggs0453fz9r2kvmv4bp-apt-dater-1.0.3.drv' failed with exit code 2
error: build of '/nix/store/y9p4liqj38431ggs0453fz9r2kvmv4bp-apt-dater-1.0.3.drv' on 'ssh://mac1' failed: builder for '/nix/store/y9p4liqj38431ggs0453fz9r2kvmv4bp-apt-dater-1.0.3.drv' failed with exit code 2
builder for '/nix/store/y9p4liqj38431ggs0453fz9r2kvmv4bp-apt-dater-1.0.3.drv' failed with exit code 1
error: build of '/nix/store/y9p4liqj38431ggs0453fz9r2kvmv4bp-apt-dater-1.0.3.drv' failed

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

gzipping man pages under /nix/store/xrz1fzppbnf2cmjdiwqdrwpyc480ifrb-apt-dater-1.0.3/share/man/
stripping (with flags -S) in /nix/store/xrz1fzppbnf2cmjdiwqdrwpyc480ifrb-apt-dater-1.0.3/lib  /nix/store/xrz1fzppbnf2cmjdiwqdrwpyc480ifrb-apt-dater-1.0.3/bin 
patching script interpreter paths in /nix/store/xrz1fzppbnf2cmjdiwqdrwpyc480ifrb-apt-dater-1.0.3
/nix/store/xrz1fzppbnf2cmjdiwqdrwpyc480ifrb-apt-dater-1.0.3/bin/adsh: interpreter directive changed from "/bin/sh" to "/nix/store/8dqlja3073hddqyhrbny9pxrz293s9bn-bash-4.4-p12/bin/sh"
/nix/store/xrz1fzppbnf2cmjdiwqdrwpyc480ifrb-apt-dater-1.0.3/lib/apt-dater/tmux-hint: interpreter directive changed from "/bin/sh" to "/nix/store/8dqlja3073hddqyhrbny9pxrz293s9bn-bash-4.4-p12/bin/sh"
/nix/store/xrz1fzppbnf2cmjdiwqdrwpyc480ifrb-apt-dater-1.0.3/lib/apt-dater/pcre-less: interpreter directive changed from "/bin/sh" to "/nix/store/8dqlja3073hddqyhrbny9pxrz293s9bn-bash-4.4-p12/bin/sh"
/nix/store/xrz1fzppbnf2cmjdiwqdrwpyc480ifrb-apt-dater-1.0.3/lib/apt-dater/cmd: interpreter directive changed from "/bin/sh" to "/nix/store/8dqlja3073hddqyhrbny9pxrz293s9bn-bash-4.4-p12/bin/sh"
/nix/store/xrz1fzppbnf2cmjdiwqdrwpyc480ifrb-apt-dater-1.0.3/lib/apt-dater/ssh-addonce: interpreter directive changed from "/bin/sh" to "/nix/store/8dqlja3073hddqyhrbny9pxrz293s9bn-bash-4.4-p12/bin/sh"
checking for references to /tmp/nix-build-apt-dater-1.0.3.drv-0 in /nix/store/xrz1fzppbnf2cmjdiwqdrwpyc480ifrb-apt-dater-1.0.3...
/nix/store/xrz1fzppbnf2cmjdiwqdrwpyc480ifrb-apt-dater-1.0.3

@Mic92
Copy link
Member

Mic92 commented Nov 29, 2017

@GrahamcOfBorg build apt-dater

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

clang-4.0: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [Makefile:459: apt-dater] Error 1
make[2]: Leaving directory '/private/tmp/nix-build-apt-dater-1.0.3.drv-0/apt-dater-1.0.3/src'
make[1]: *** [Makefile:419: all-recursive] Error 1
make[1]: Leaving directory '/private/tmp/nix-build-apt-dater-1.0.3.drv-0/apt-dater-1.0.3'
make: *** [Makefile:358: all] Error 2
builder for '/nix/store/w5l7lw72pzlajpbmlb4y90zii898yvp2-apt-dater-1.0.3.drv' failed with exit code 2
error: build of '/nix/store/w5l7lw72pzlajpbmlb4y90zii898yvp2-apt-dater-1.0.3.drv' on 'ssh://mac1' failed: builder for '/nix/store/w5l7lw72pzlajpbmlb4y90zii898yvp2-apt-dater-1.0.3.drv' failed with exit code 2
builder for '/nix/store/w5l7lw72pzlajpbmlb4y90zii898yvp2-apt-dater-1.0.3.drv' failed with exit code 1
error: build of '/nix/store/w5l7lw72pzlajpbmlb4y90zii898yvp2-apt-dater-1.0.3.drv' failed

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

gzipping man pages under /nix/store/ya7krfhvb0mdb4f9vbpd9z1k71c7kccv-apt-dater-1.0.3/share/man/
stripping (with flags -S) in /nix/store/ya7krfhvb0mdb4f9vbpd9z1k71c7kccv-apt-dater-1.0.3/lib  /nix/store/ya7krfhvb0mdb4f9vbpd9z1k71c7kccv-apt-dater-1.0.3/bin 
patching script interpreter paths in /nix/store/ya7krfhvb0mdb4f9vbpd9z1k71c7kccv-apt-dater-1.0.3
/nix/store/ya7krfhvb0mdb4f9vbpd9z1k71c7kccv-apt-dater-1.0.3/bin/adsh: interpreter directive changed from "/bin/sh" to "/nix/store/8dqlja3073hddqyhrbny9pxrz293s9bn-bash-4.4-p12/bin/sh"
/nix/store/ya7krfhvb0mdb4f9vbpd9z1k71c7kccv-apt-dater-1.0.3/lib/apt-dater/tmux-hint: interpreter directive changed from "/bin/sh" to "/nix/store/8dqlja3073hddqyhrbny9pxrz293s9bn-bash-4.4-p12/bin/sh"
/nix/store/ya7krfhvb0mdb4f9vbpd9z1k71c7kccv-apt-dater-1.0.3/lib/apt-dater/pcre-less: interpreter directive changed from "/bin/sh" to "/nix/store/8dqlja3073hddqyhrbny9pxrz293s9bn-bash-4.4-p12/bin/sh"
/nix/store/ya7krfhvb0mdb4f9vbpd9z1k71c7kccv-apt-dater-1.0.3/lib/apt-dater/cmd: interpreter directive changed from "/bin/sh" to "/nix/store/8dqlja3073hddqyhrbny9pxrz293s9bn-bash-4.4-p12/bin/sh"
/nix/store/ya7krfhvb0mdb4f9vbpd9z1k71c7kccv-apt-dater-1.0.3/lib/apt-dater/ssh-addonce: interpreter directive changed from "/bin/sh" to "/nix/store/8dqlja3073hddqyhrbny9pxrz293s9bn-bash-4.4-p12/bin/sh"
checking for references to /tmp/nix-build-apt-dater-1.0.3.drv-0 in /nix/store/ya7krfhvb0mdb4f9vbpd9z1k71c7kccv-apt-dater-1.0.3...
/nix/store/ya7krfhvb0mdb4f9vbpd9z1k71c7kccv-apt-dater-1.0.3

@Mic92
Copy link
Member

Mic92 commented Nov 29, 2017

@enko can you please limit the build with meta.platforms to linux unless you indent to fix the build error on darwin?

@enko
Copy link
Contributor Author

enko commented Nov 30, 2017

@Mic92 can I see the full output of the build on darwin, so I might see what causes the build failure?

version = "1.0.3";

src = fetchurl {
url = "https://github.com/DE-IBH/apt-dater/archive/v${version}.tar.gz";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github archives change over time, use fetchFromGitHub or fetchzip.

@Mic92
Copy link
Member

Mic92 commented Dec 1, 2017

@grahamc there is some log for the evaluation, but is the build output also fully logged?

src = fetchFromGitHub {
owner = "DE-IBH";
repo = "apt-dater";
rev = "v1.0.3";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to rev = "v${version}";

Copy link
Member

@matthewbauer matthewbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge conflict/see @peteroeg's comment

just because the maintainers file format has changed in the meantime
and add c0bw3b as a maintainer
and not automake115x which is not a valid attribute anymore
@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 26, 2018

@GrahamcOfBorg build apt-dater

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: apt-dater

Partial log (click to expand)

         'configure.ac' or m4 files included by 'configure.ac'.
         The 'aclocal' program is part of the GNU Automake package:
         <http://www.gnu.org/software/automake>
         It also requires GNU Autoconf, GNU m4 and Perl in order to run:
         <http://www.gnu.org/software/autoconf>
         <http://www.gnu.org/software/m4/>
         <http://www.perl.org/>
make: *** [Makefile:388: aclocal.m4] Error 127
builder for '/nix/store/azz4y6acnhc1j6fxadlyxdvz3y25vjl7-apt-dater-1.0.3.drv' failed with exit code 2
error: build of '/nix/store/azz4y6acnhc1j6fxadlyxdvz3y25vjl7-apt-dater-1.0.3.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: apt-dater

Partial log (click to expand)

         'configure.ac' or m4 files included by 'configure.ac'.
         The 'aclocal' program is part of the GNU Automake package:
         <http://www.gnu.org/software/automake>
         It also requires GNU Autoconf, GNU m4 and Perl in order to run:
         <http://www.gnu.org/software/autoconf>
         <http://www.gnu.org/software/m4/>
         <http://www.perl.org/>
make: *** [Makefile:388: aclocal.m4] Error 127
builder for '/nix/store/az6yppbisk242h9mwvz94cfbkrv1pwy9-apt-dater-1.0.3.drv' failed with exit code 2
error: build of '/nix/store/az6yppbisk242h9mwvz94cfbkrv1pwy9-apt-dater-1.0.3.drv' failed

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 26, 2018

@GrahamcOfBorg build apt-dater

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: apt-dater

Partial log (click to expand)

gzipping man pages under /nix/store/8ckg7035ixkc9lakx3r52ikpmgcm1g0p-apt-dater-1.0.3/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8ckg7035ixkc9lakx3r52ikpmgcm1g0p-apt-dater-1.0.3/lib  /nix/store/8ckg7035ixkc9lakx3r52ikpmgcm1g0p-apt-dater-1.0.3/bin
patching script interpreter paths in /nix/store/8ckg7035ixkc9lakx3r52ikpmgcm1g0p-apt-dater-1.0.3
/nix/store/8ckg7035ixkc9lakx3r52ikpmgcm1g0p-apt-dater-1.0.3/bin/adsh: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/8ckg7035ixkc9lakx3r52ikpmgcm1g0p-apt-dater-1.0.3/lib/apt-dater/ssh-addonce: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/8ckg7035ixkc9lakx3r52ikpmgcm1g0p-apt-dater-1.0.3/lib/apt-dater/pcre-less: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/8ckg7035ixkc9lakx3r52ikpmgcm1g0p-apt-dater-1.0.3/lib/apt-dater/tmux-hint: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/8ckg7035ixkc9lakx3r52ikpmgcm1g0p-apt-dater-1.0.3/lib/apt-dater/cmd: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/8ckg7035ixkc9lakx3r52ikpmgcm1g0p-apt-dater-1.0.3...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: apt-dater

Partial log (click to expand)

gzipping man pages under /nix/store/glc2wbyadjvbm4h32ww4kpj0n4w5gjxb-apt-dater-1.0.3/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/glc2wbyadjvbm4h32ww4kpj0n4w5gjxb-apt-dater-1.0.3/lib  /nix/store/glc2wbyadjvbm4h32ww4kpj0n4w5gjxb-apt-dater-1.0.3/bin
patching script interpreter paths in /nix/store/glc2wbyadjvbm4h32ww4kpj0n4w5gjxb-apt-dater-1.0.3
/nix/store/glc2wbyadjvbm4h32ww4kpj0n4w5gjxb-apt-dater-1.0.3/lib/apt-dater/pcre-less: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/glc2wbyadjvbm4h32ww4kpj0n4w5gjxb-apt-dater-1.0.3/lib/apt-dater/tmux-hint: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/glc2wbyadjvbm4h32ww4kpj0n4w5gjxb-apt-dater-1.0.3/lib/apt-dater/ssh-addonce: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/glc2wbyadjvbm4h32ww4kpj0n4w5gjxb-apt-dater-1.0.3/lib/apt-dater/cmd: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/glc2wbyadjvbm4h32ww4kpj0n4w5gjxb-apt-dater-1.0.3/bin/adsh: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/glc2wbyadjvbm4h32ww4kpj0n4w5gjxb-apt-dater-1.0.3...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants