betaflight: init at 3.2.3 #33365
Merged
betaflight: init at 3.2.3 #33365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Jan 3, 2018
|
|
||
| version = "3.2.3"; | ||
|
|
||
| in stdenv.mkDerivation rec { |
There was a problem hiding this comment.
Can you you add meta attributes, such as license, platforms, maintainers and homepage?
There was a problem hiding this comment.
Whoops, that got left behind in one of my local commits.
elitak
force-pushed
the
betaflight
branch
2 times, most recently
from
bebdb14
to
6577aef
Compare
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This derivation builds the firmware for as many targets as possible as
.hexfiles inresult/(should they be placed in some subdirectory?). The tool used to flash this is a chrome plugin, which I may add a derivation for later, but for now is available in the Google chrome web store.I wasn't able to test it, but this may build okay on windows, so possibly,
meta.platformsshould be changed tox86.Maybe this should go in a directory other than
pkgs/development/stm32? I have plans to add other branches of flight-controller firmware into there.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"