Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/redis: remove static uid/gid assignment #33370

Merged
merged 1 commit into from Jan 4, 2018
Merged

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jan 3, 2018

all files are chowned on startup

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

all files are chowned on startup
@bjornfor
Copy link
Contributor

bjornfor commented Jan 3, 2018

General thoughts. How do we know for which services it's OK to do recursive chown on startup? I personally like it, but I think I've seen someone removing such code because on big trees it may cause service startup timeout. (Or otherwise an undesirable long startup delay.)

@Mic92
Copy link
Member Author

Mic92 commented Jan 4, 2018

For services with a large amounts of files, we prefer static uids. Services usually fall into this category are databases, mail daemons or daemons maintaining media libraries. Also redis is a database, it does only maintain a single file for the database. When we upgrade to the next systemd version, we can switch to DynamicUser for services without static uid.

@Mic92 Mic92 merged commit 2387c15 into NixOS:master Jan 4, 2018
@Mic92 Mic92 deleted the redis branch September 6, 2018 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants