Update LLVM default 4 -> 5 #33374

dtzWill · 2018-01-03T14:12:15Z

Motivation for this change

Bit overdue, submitting to get this started and to track testing.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

Darwin will certainly want to test this, cc @LnL7 @copumpkin

LnL7 · 2018-01-03T18:26:27Z

Not sure why yet, but this causes some infinite recursion on darwin.

dtzWill · 2018-01-03T18:42:55Z

@LnL7 eep, confirmed and just pushed a fix :).

dtzWill · 2018-01-06T20:49:09Z

(updating to target staging instead)

dtzWill · 2018-01-09T11:34:01Z

Ping :).

LnL7

Looks like this pulls in a bunch of extra stuff that shouldn't be in the darwin stdenv.

output '/nix/store/30md77sa06dyz4xck99fzfj8v9rwc6i2-stdenv-darwin' is not allowed to refer to the following paths:
	/nix/store/4q1c84f1ynfvsd85a932375sg0jc89v8-bootstrap-tools
	/nix/store/54dlyn7qxp4lpjk55a8fr4s8bcslyqvc-coreutils-8.29
	/nix/store/5jp8k3v9yi342wk1d34d9qqc8qycprh4-sqlite-3.21.0
	/nix/store/9b2kv6px747r7q3x33vd0msbsr747bms-gdbm-1.13
	/nix/store/d5wdi9cjqaq8052qdw4xi1vqk90630mc-python-2.7.14
	/nix/store/gy7qv8z26ig3dbg1g9g970ys01hnbvyq-readline-6.3p08
	/nix/store/m212ikxbnvhiycw54110v2bslclam2gs-gmp-6.1.2
	/nix/store/sa86zrsrn1m4ihm0r4159vxr029w8mh9-bzip2-1.0.6.0.1
	/nix/store/xy0jx6gkv4bjs8xyi52vwn0kn8anx3in-ncurses-5.9

dtzWill · 2018-01-09T23:02:37Z

Thanks for giving it a go... bummer about the extra references! Hmm.

Oh I just noticed this: 72d9016

Could that be related/cause?

vcunat · 2018-01-09T23:30:52Z

I don't expect the version used to bootstrap from would be that important to extend closure.

LnL7 · 2018-01-09T23:31:31Z

I'm pretty sure that's unrelated, however I wouldn't be surprised if the bootstrap tools also need some changes in order to work. I'll try to take a look at this soon.

dtzWill · 2018-01-14T22:22:52Z

python is the key:

$ nix why-depends /nix/store/j3r092ykx9ywnjd8x4m2zkiz014zb2fp-llvm-5.0.1 /nix/store/6yb5rvr6rvgvx8ylpchwz808djfw07rb-python-2.7.14 --all
/nix/store/j3r092ykx9ywnjd8x4m2zkiz014zb2fp-llvm-5.0.1
╚═══share/opt-viewer/opt-diff.py: …#!/nix/store/6yb5rvr6rvgvx8ylpchwz808djfw07rb-python-2.7.14/bin/python2.7..fr…
    share/opt-viewer/opt-stats.py: …#!/nix/store/6yb5rvr6rvgvx8ylpchwz808djfw07rb-python-2.7.14/bin/python2.7..fr…
    share/opt-viewer/opt-viewer.py: …#!/nix/store/6yb5rvr6rvgvx8ylpchwz808djfw07rb-python-2.7.14/bin/python2.7..fr…
    share/opt-viewer/optrecord.py: …#!/nix/store/6yb5rvr6rvgvx8ylpchwz808djfw07rb-python-2.7.14/bin/python2.7..fr…
    => /nix/store/6yb5rvr6rvgvx8ylpchwz808djfw07rb-python-2.7.14

I'll submit a PR fixing this once I finish compiling and testing it :).

dtzWill · 2018-01-16T18:20:13Z

Can someone test if that PR fixes the Darwin bootstrap problem?

Or maybe save our energy and build hours for 6 in a few months? :)

LnL7 · 2018-01-31T23:07:32Z

The python output resolves that issue, next is darwin.ICU that doesn't build.

1 warning generated.
   c++	 ...  japancal.cpp
   c++	 ...  gregoimp.cpp
   c++	 ...  hebrwcal.cpp
   c++	 ...  indiancal.cpp
   c++	 ...  chnsecal.cpp
   c++	 ...  cecal.cpp
   c++	 ...  coptccal.cpp
   c++	 ...  nfsubs.cpp
   c++	 ...  dangical.cpp
   c++	 ...  ethpccal.cpp
   c++	 ...  coleitr.cpp
   c++	 ...  coll.cpp
   c++	 ...  sortkey.cpp
   c++	 ...  bocsu.cpp
   c++	 ...  ucoleitr.cpp
   c++	 ...  ucol.cpp
ucoleitr.cpp:323:28: error: qualified reference to 'UCollationPCE' is a constructor name rather than a type in this context
    return (UCollationPCE::UCollationPCE(elems)).nextProcessed(ixLow, ixHigh, status);
                           ^
ucoleitr.cpp:387:28: error: qualified reference to 'UCollationPCE' is a constructor name rather than a type in this context
    return (UCollationPCE::UCollationPCE(elems)).previousProcessed(ixLow, ixHigh, status);
                           ^
2 errors generated.
*** Failed compilation command follows: ----------------------------------------------------------
c++ -DU_ATTRIBUTE_DEPRECATED= -DU_I18N_IMPLEMENTATION -DSTD_INSPIRED -DMAC_OS_X_VERSION_MIN_REQUIRED=1070 -DU_HAVE_ATOMIC=1 -DU_DISABLE_RENAMING=1 -I. -I../common -DU_SHOW_CPLUSPLUS_API=1 -DU_SHOW_INTERNAL_API=1 -DU_TIMEZONE=timezone -DICU_DATA_DIR="/usr/share/icu/" -g -Os -Wglobal-constructors -fno-exceptions -fvisibility=hidden -fvisibility-inlines-hidden -fno-common -c -dynamic -MMD -MT ucoleitr.d ucoleitr.o ucoleitr.ao -o ucoleitr.o ucoleitr.cpp

LnL7 · 2018-02-01T19:13:40Z

https://hydra.nixos.org/eval/1430526?compare=1430378#tabs-now-fail

dtzWill · 2018-02-02T16:55:40Z

The fastjet PR fixes the new failures!

Although it looks like many were aborted so we're not done yet...

copumpkin · 2018-02-12T13:12:46Z

@dtzWill @LnL7 \o/ nice!

vcunat · 2018-02-13T18:10:22Z

qt4 build seems broken on Darwin (noticed accidentally).

dtzWill · 2018-02-13T18:15:35Z

qt4 build seems broken on Darwin (noticed accidentally).

I believe that's due to the same problem clang-5 had with qt5 (update: yep here's the qt5 job, compare the two log tails-- can whatever fixed qt5 be also done for qt4?

LnL7 · 2018-02-13T18:16:58Z

I fixed qt59 and qt510, must have skipped over qt4 accidentally.

vcunat · 2018-02-15T21:30:35Z

This is still causing lots of darwin build regressions on staging, most of which is pysqlite killing all haskell. (When testing, beware of the new stdenv-rebuilding commit on staging.)

LnL7 · 2018-02-15T21:35:14Z

Hmm, I don't think that's related to the clang update. This is a build from my test jobset https://hydra.nixos.org/build/68589517

LnL7 · 2018-02-15T21:39:49Z

-Lsh: -Lpkg-config: -Lcommand -Lnot -Lfound 😄

vcunat · 2018-02-15T21:42:36Z

The same for includes as well. Perhaps it will be enough to just add pkgconfig to nativeBuildInputs?

LnL7 · 2018-02-15T21:43:17Z

I'm taking a look at it.

vcunat · 2018-02-15T21:47:23Z

Even with a fix, I wonder whether to just merge the hydra-built commit with the fix commit atop, directly to master... as I'd rather finish this iteration before rebuilding the world again. Alternatives I can see: (2) temporary revert or (3) yet another temporary branch and jobset.

LnL7 · 2018-02-15T21:54:39Z

I guess that's ok, the amount of rebuilds on master won't be super bad.

LnL7 · 2018-02-15T22:14:33Z

@vcunat Can you join irc?

dtzWill mentioned this pull request Jan 3, 2018

Build error for llvm_5 on NixOS (unstable) #33369

Closed

GrahamcOfBorg added 10.rebuild-darwin-stdenv 10.rebuild-darwin: 501+ 10.rebuild-linux: 11-100 labels Jan 3, 2018

dtzWill force-pushed the update/llvm-5-default branch from d88349e to ead2dcd Compare January 6, 2018 20:48

dtzWill changed the base branch from master to staging January 6, 2018 20:48

GrahamcOfBorg added 10.rebuild-linux: 501+ and removed 10.rebuild-linux: 11-100 labels Jan 6, 2018

LnL7 reviewed Jan 9, 2018

View reviewed changes

LnL7 self-assigned this Jan 9, 2018

dtzWill mentioned this pull request Jan 14, 2018

llvm-5: add extra 'python' output for opt-viewer tool #33871

Merged

8 tasks

dtzWill mentioned this pull request Feb 2, 2018

fastjet: Fix build w/clang5 #34534

Merged

8 tasks

dtzWill and others added 4 commits February 6, 2018 23:38

llvm-packages: update default 4 -> 5

19d8850

llvm-packages: cleanup

db7e0ae

ICU: fix build with clang-5

79f4353

pixman: fix clang5 build

5af41b7

LnL7 force-pushed the update/llvm-5-default branch from ead2dcd to 5af41b7 Compare February 6, 2018 22:40

dtzWill requested a review from FRidh as a code owner February 6, 2018 22:40

dtzWill requested a review from peti as a code owner February 6, 2018 22:40

LnL7 added this to the 18.03 milestone Feb 6, 2018

peti removed their request for review February 7, 2018 07:27

LnL7 merged commit 69779a5 into NixOS:staging Feb 11, 2018

dtzWill deleted the update/llvm-5-default branch February 13, 2018 18:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update LLVM default 4 -> 5 #33374

Update LLVM default 4 -> 5 #33374

dtzWill commented Jan 3, 2018

LnL7 commented Jan 3, 2018

dtzWill commented Jan 3, 2018

dtzWill commented Jan 6, 2018

dtzWill commented Jan 9, 2018

LnL7 left a comment

dtzWill commented Jan 9, 2018

vcunat commented Jan 9, 2018

LnL7 commented Jan 9, 2018 •

edited

dtzWill commented Jan 14, 2018

dtzWill commented Jan 16, 2018

LnL7 commented Jan 31, 2018

LnL7 commented Feb 1, 2018 •

edited

dtzWill commented Feb 2, 2018 •

edited

copumpkin commented Feb 12, 2018

vcunat commented Feb 13, 2018

dtzWill commented Feb 13, 2018

LnL7 commented Feb 13, 2018

vcunat commented Feb 15, 2018 •

edited

LnL7 commented Feb 15, 2018

LnL7 commented Feb 15, 2018

vcunat commented Feb 15, 2018

LnL7 commented Feb 15, 2018

vcunat commented Feb 15, 2018 •

edited

LnL7 commented Feb 15, 2018

LnL7 commented Feb 15, 2018

Update LLVM default 4 -> 5 #33374

Update LLVM default 4 -> 5 #33374

Conversation

dtzWill commented Jan 3, 2018

Motivation for this change

Things done

LnL7 commented Jan 3, 2018

dtzWill commented Jan 3, 2018

dtzWill commented Jan 6, 2018

dtzWill commented Jan 9, 2018

LnL7 left a comment

Choose a reason for hiding this comment

dtzWill commented Jan 9, 2018

vcunat commented Jan 9, 2018

LnL7 commented Jan 9, 2018 • edited

dtzWill commented Jan 14, 2018

dtzWill commented Jan 16, 2018

LnL7 commented Jan 31, 2018

LnL7 commented Feb 1, 2018 • edited

dtzWill commented Feb 2, 2018 • edited

copumpkin commented Feb 12, 2018

vcunat commented Feb 13, 2018

dtzWill commented Feb 13, 2018

LnL7 commented Feb 13, 2018

vcunat commented Feb 15, 2018 • edited

LnL7 commented Feb 15, 2018

LnL7 commented Feb 15, 2018

vcunat commented Feb 15, 2018

LnL7 commented Feb 15, 2018

vcunat commented Feb 15, 2018 • edited

LnL7 commented Feb 15, 2018

LnL7 commented Feb 15, 2018

LnL7 commented Jan 9, 2018 •

edited

LnL7 commented Feb 1, 2018 •

edited

dtzWill commented Feb 2, 2018 •

edited

vcunat commented Feb 15, 2018 •

edited

vcunat commented Feb 15, 2018 •

edited