ncurses: fix ncurses6 build w/clang #33376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somewhat amusingly given its name, "clang.patch" applies to both 5 and 6
but is the cause of ncurses6 breakage on 6 but is required on 5...
gcc is happy in all four configurations:
5 5p 6 6p
gcc ✓ ✓ ✓ ✓
clang ✗ ✓ ✓ ✗
Which is why this commit enables the patch for 5 but not 6;
this matches behavior in Gentoo, for example.
For further simplification, we also use gcc-5 patch regardless.
|
@dezgeg thanks! Looks like ncurses6 might be in Darwin's future, then! 😁 |
I knew none when committing it (I believe), and I still know none. |
LnL7
approved these changes
Jan 3, 2018
LnL7
added
the
8.has: port to stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Un-break ncurses6 on clang (it's been broken a long time).
Recent hydra log demonstrating this on Darwin: https://hydra.nixos.org/build/66447097/nixlog/3
Follow-up might want to enable ncurses6 on Darwin instead of using 5, not sure if there are other reasons for using 5 on Darwin but 6 on Linux. (cc @LnL7 @copumpkin).
First commit simplifies and is what I think is "best"; second shows what it would look like to un-break ncurses6 on clang but avoids triggering mass-rebuild... at the cost of being significantly uglier :).
I'm good with either being merged, wasn't sure how folks would feel.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)