haskell generic-builder: Fix Dependencies #33368
Closed
+211
−120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
force-pushed
the
haskell-fix-deps
branch
from
b372ce8 to
f1dbf51
Compare
Ericson2314
requested review from
ttuegel and
domenkozar
and removed request for
edolstra
Ericson2314
changed the title
Ericson2314
changed the title
8 tasks
|
Can you please re-base on top of the current |
|
Why not set the flags through |
Ericson2314
force-pushed
the
haskell-fix-deps
branch
from
f1dbf51 to
3d1e228
Compare
The idea is cabal-install / `./Setup` will know about C headers and libs, but the C compiler itself will not directly. - nativeGhc -> depsBuildBuild - Setup.hs libraries -> nativeBuildInputs - other tools -> nativeBuildInputs - libraries -> (propagated)NativeBuildInputs Also, I'm trying to start the process of smoothing over the differences between our builder and shell env. - Everyone gets tools - Everyone only accesses C through Cabal
Use the clang sierrahack stdenv instead
Also make sure that Setup.hs dependencies are kept disjoint
Ericson2314
force-pushed
the
haskell-fix-deps
branch
from
3d1e228 to
ef6161b
Compare
|
OK the later commits I added aren't really appropriate at this time, as I need to dust off my darwin hack first and make it appropriate for |
|
Will revisit after #26799, which is very close. |
|
What is the status of this pull request? |
|
Closing this as it's out of sync. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The idea is that one can do
cabal configure $NIX_CABAL_FOREIGN_FLAGSwhich ensure that Cabal knows about C headers and libs, but not the c compiler itself.Also, I'm trying to start the process of smoothing over the differences between our builder and shell env.
-systemor-LflagsI'd like to go even farther and
ghcWithPackages--with-package-dbto./Setup/NIX_CABAL_FOREIGN_FLAGSghcWithPackages, OTOH, should use acc-with-packages, for a completely (cabal-install or stack)-free persistent environments. Granted, I don't know why one would want to not use either of these tools, but ifghcWithPackagescontinues to exist with the plan above, this gives it its own clear-cut and distinct niche.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)