Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returns the effective, real group and user ID of the current process #5515

Closed
wants to merge 21 commits into from

Conversation

Wulfklaue
Copy link

The code got posted a few days ago on Gitter when somebody asked how to get the effective and real group/user ID on Linux but nobody has committed the change to the Crystal source.

@j8r
Copy link
Contributor

j8r commented Jan 3, 2018

This addition needs to come with some specs.
You should also squash all this commits to one to avoid polluting the project's history.

@Wulfklaue
Copy link
Author

This addition needs to come with some specs.

As in? The summary and source comments are self explaining...

You should also squash all this commits to one to avoid polluting the project's history.

I understand but do not have the option on the web interface. Those changes have been done on the web not a local client ( note: i do not use Git a lot ) .

@RX14
Copy link
Contributor

RX14 commented Jan 3, 2018

I strongly suggest you learn to use git, it'll make it much much easier for everyone reviewing the PR, and it's a valuable skill for yourself.

By specs, @j8r means adding automated tests in the specs directory.

@j8r
Copy link
Contributor

j8r commented Jan 3, 2018

@Wulfklaue , the basics of git aren't that hard, only if you use more advanced features.
Basically with git pull https://github.com/Wulfklaue/crystal, git reset --soft HEAD^(to remove commits), git commit -am "my message" and git push -f(but try avoiding -f when possible) you can do the job.
The best will be to use git rebase -i, but this is advanced.
For best practises, you can browse the project's history (PR, commits) to see how people do, and learn from external docs.

@Wulfklaue Wulfklaue closed this Feb 13, 2018
@chris-huxtable
Copy link
Contributor

This Is included in #5627.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants