Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.bytestring-progress: 1.0.7 -> 1.0.8 #33373

Closed
wants to merge 1 commit into from
Closed

haskellPackages.bytestring-progress: 1.0.7 -> 1.0.8 #33373

wants to merge 1 commit into from

Conversation

iblech
Copy link
Contributor

@iblech iblech commented Jan 3, 2018

Motivation for this change

Without this bump, the handy time tracker arbtt (which is also in our repository) doesn't build correctly. (The problem is that the old bytestring-progress package has a too restrictive on the time package.)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@iblech iblech requested a review from peti as a code owner January 3, 2018 13:41
peti
peti requested changes Jan 3, 2018
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't edit this file. Please read the comment at the very top of it.

@iblech
Copy link
Contributor Author

iblech commented Jan 3, 2018

Sorry! I grepped for bytestring-progress and was therefore teleported to the middle of the file. I'm closing this pull request (and opening a somewhat related issue).

@iblech iblech closed this Jan 3, 2018
@michaelpj
Copy link
Contributor

There's already #33363, and this should be fixed in the next hackage update.

@iblech iblech mentioned this pull request Jan 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@iblech @michaelpj @peti @GrahamcOfBorg