Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build-support: clean-up fetchSvn #32814

Merged
merged 1 commit into from Dec 24, 2017
Merged

build-support: clean-up fetchSvn #32814

merged 1 commit into from Dec 24, 2017

Conversation

fahadsadah
Copy link
Contributor

@fahadsadah fahadsadah commented Dec 18, 2017 •
edited

Motivation for this change

Remove old workaround rendered unnecessary by af9db52

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@fahadsadah
build-support: tidy fetchSvn
60e937b 
Remove old workaround rendered unnecessary by af9db52
@fahadsadah fahadsadah changed the title build-support: tidy fetchSvn build-support: clean-up fetchSvn Dec 22, 2017
@orivej orivej merged commit c4be328 into NixOS:master Dec 24, 2017
@orivej
Copy link
Contributor

orivej commented Dec 24, 2017

Thank you!

@fahadsadah fahadsadah deleted the patch-1 branch December 24, 2017 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fahadsadah @orivej @GrahamcOfBorg