Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atom-beta: 1.23.0-beta0->1.24.0-beta1 #32810

Merged
merged 1 commit into from Dec 18, 2017
Merged

Conversation

lierdakil
Copy link
Contributor

Motivation for this change

A simple version bump; main was updated to 1.23 in 0be3f2c, it doesn't make sense to keep 1.23.0-beta0 around, does it?

/cc @NeQuissimus

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Note: I have no idea what I'm doing. Seriously. I was just mimicking 0be3f2c. I think hash at least is correct (computed via nix-hash --base32 --type sha256 --flat). I hope I'm not just needlessly wasting anyone's time.

@NeQuissimus
Copy link
Member

I ran the editor and it works fine. Thank you

@NeQuissimus NeQuissimus merged commit 8faa0c9 into NixOS:master Dec 18, 2017
@lierdakil lierdakil deleted the patch-1 branch December 18, 2017 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants