Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mousepad: backport fix of issue 12134, resolves #14862 #32818

Merged
merged 1 commit into from Dec 19, 2017

Conversation

lukateras
Copy link
Member

@lukateras lukateras commented Dec 18, 2017

Motivation for this change

Resolves #14862. This should also be ported to stable.

https://bugzilla.xfce.org/show_bug.cgi?id=12134

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej
Copy link
Contributor

orivej commented Dec 18, 2017

@lukateras
Copy link
Member Author

lukateras commented Dec 18, 2017

No: some hunks of the patch had to be rewritten on top of 0.4.0, some hunks didn't apply because they were referencing a not-yet-existing code (revert)...

@lukateras lukateras merged commit c1cc1a7 into NixOS:master Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants