gnutar: 1.29 -> 1.30 #32816
Merged
gnutar: 1.29 -> 1.30 #32816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
vcunat
approved these changes
Dec 19, 2017
vcunat
added a commit
that referenced
this pull request
Dec 19, 2017
|
Thanks @vcunat! |
|
I think this regression is related: https://hydra.nixos.org/build/66305655 but ATM I can't at all understand what's happening there. |
|
Oh, I see, it was during a build, not during fetch or something. Fixed now. |
vcunat
added a commit
that referenced
this pull request
Dec 26, 2017
|
@vcunat thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unclear when to merge this to staging, because @orivej wants to make sure something else happens first.
Also, I personally would love to get this into 17.09 (#32824) but if others think it's not worthwhile, I'll live. @fpletz @globin
Motivation for this change
Gnutar just got a new release that includes a CVE patch that we were applying manually before, and also it fixes the
--numeric-ownerflag to get us deterministic cross-platform behavior.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)