ghc: bootstrap 8.2.2 with 8.2.1-binary. #33350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. But first @peti should push to |
|
Test builds are running at https://hydra.nixos.org/jobset/nixpkgs/haskell-updates. |
Ericson2314
approved these changes
Jan 3, 2018
|
The tests show almost no regressions. The nixpkgs diff since the last one also includes a bunch of unrelated changes (Haskell version bumps, my cross big rebuild, etc), so I'm going to say those few regressions are not this PR's fault. Also I need this PR merged for cross ghc, so I'm going to go ahead and merge it. @peti hope that is ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
8.2.1-binary will be necessary to bootstrap
aarch64-linuxas 7.10.3-binary is not supported on that platform.Things done
I have tested this on
x86_64-linuxby bootstrapping GHC and building a subset ofhaskellPackages.armv7l-linuxandaarch64-linuxstill cannot bootstrap GHC due to unrelated issues, but as this is a prerequisite and it will cause a rebuild ofhaskellPackages, it might be a good idea to check it in before the other changes needed to get those platforms working, especially considering it's a straightforward change that shouldn't need any real review.build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)