New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clang: add lib output #33342
clang: add lib output #33342
Conversation
Currently clang-unwrapped can't be used as a buildInput without also shadowing clang/clang++ of a clang based stdenv.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice in principle! Is make-bootstrap-tools.nix affected?
Probably, but that should be included in my build. |
@LnL7 err, it would only copy over the outputs manually specified, so I don't think so? |
You're right, I though maybe all of the libs where copied https://github.com/NixOS/nixpkgs/blob/79835e8086a49c20854cd78f554d4ecbafbb2815/pkgs/stdenv/darwin/make-bootstrap-tools.nix#L82 |
Hmm, think I got this mixed up with some other changes and forgot to test properly. |
BTW, staging should be merged soon, due to a security update of glibc. |
I just made a partial fix for cmake projects, anything else important I should look at except for firefox? |
This is some list of packages, most of them newly failed by clang: https://hydra.nixos.org/eval/1426338?filter=aarch64&compare=1426591&full=#tabs-now-fail |
Fixes cmake build issues introduced in NixOS#33342.
Most of the issues should be fixed now, let me know if you find anything else. |
|
^^ I'm sorry; I didn't realize that Hydra hasn't evaluated all of your fixes yet. |
Motivation for this change
This should make it easier to depend on libclang without shadowing clang/clang++ on darwin.
/cc @copumpkin @Ericson2314
Still needs testing.
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)