Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang: add lib output #33342

Merged
merged 2 commits into from Jan 7, 2018
Merged

clang: add lib output #33342

merged 2 commits into from Jan 7, 2018

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Jan 2, 2018

Motivation for this change

This should make it easier to depend on libclang without shadowing clang/clang++ on darwin.

/cc @copumpkin @Ericson2314

Still needs testing.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Currently clang-unwrapped can't be used as a buildInput without also
shadowing clang/clang++ of a clang based stdenv.
Copy link
Member

@copumpkin copumpkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice in principle! Is make-bootstrap-tools.nix affected?

@LnL7
Copy link
Member Author

LnL7 commented Jan 2, 2018

Probably, but that should be included in my build.

@Ericson2314
Copy link
Member

@LnL7 err, it would only copy over the outputs manually specified, so I don't think so?

@LnL7
Copy link
Member Author

LnL7 commented Jan 2, 2018

@LnL7 LnL7 changed the base branch from master to staging January 3, 2018 19:23
@LnL7 LnL7 merged commit e66a5f8 into NixOS:staging Jan 7, 2018
@LnL7 LnL7 deleted the clang-outputs branch January 7, 2018 08:43
@vcunat
Copy link
Member

vcunat commented Jan 16, 2018

I suspect this broke some reverse dependencies, e.g. lldb (multiple versions) or firefox.

@LnL7
Copy link
Member Author

LnL7 commented Jan 16, 2018

Hmm, think I got this mixed up with some other changes and forgot to test properly.

@vcunat
Copy link
Member

vcunat commented Jan 16, 2018

BTW, staging should be merged soon, due to a security update of glibc.

@LnL7
Copy link
Member Author

LnL7 commented Jan 16, 2018

I just made a partial fix for cmake projects, anything else important I should look at except for firefox?

@vcunat
Copy link
Member

vcunat commented Jan 16, 2018

This is some list of packages, most of them newly failed by clang: https://hydra.nixos.org/eval/1426338?filter=aarch64&compare=1426591&full=#tabs-now-fail

LnL7 added a commit to LnL7/nixpkgs that referenced this pull request Jan 16, 2018
Fixes cmake build issues introduced in NixOS#33342.
@LnL7
Copy link
Member Author

LnL7 commented Jan 16, 2018

Most of the issues should be fixed now, let me know if you find anything else.

@vcunat
Copy link
Member

vcunat commented Jan 17, 2018

- [ ] ycmd https://hydra.nixos.org/build/67630571

@vcunat
Copy link
Member

vcunat commented Jan 17, 2018

^^ I'm sorry; I didn't realize that Hydra hasn't evaluated all of your fixes yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants