pandoc: fix build by using buildDepends to match cabal file #33352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previously used dependency hsb2hs was a build-tools dependency, but file-embed is build-depends: jgm/pandoc@ff991d1 Fixes NixOS#33349
|
This seems straightforward, especially given the link to upstream's cabal that we were incorrectly matching locally. Don't mean to be impatient but given the breakage indicated by the rebuild numbers (those packages can't build until pandoc is fixed), don't want to have this sitting around without reason :). LMK if there's anything I can do to help. Thanks! |
LnL7
approved these changes
Jan 3, 2018
|
The manual build also depends on this https://hydra.nixos.org/build/67118641 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previously used dependency hsb2hs was a build-tools dependency,
but file-embed is build-depends:
jgm/pandoc@ff991d1
Fixes #33349
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)