haskellPackages.lzma: loosen version bounds for test dependencies #33360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peti
requested changes
Jan 3, 2018
| @@ -566,6 +566,9 @@ self: super: { | |||
| # https://github.com/alphaHeavy/lzma-enumerator/issues/3 | |||
| lzma-enumerator = dontCheck super.lzma-enumerator; | |||
|
|
|||
| # Unpin some versions | |||
| lzma = appendPatch super.lzma ./patches/lzma-tests.patch; | |||
There was a problem hiding this comment.
Could you please report this issue to @hvr at https://github.com/hvr/lzma/issues and add the link to that issue into the comment here? That makes it easier for other people to decide in the future whether the issue still exists.
There was a problem hiding this comment.
Please add that URL into the source code; it should replace the "Unpin some versions" comment.
|
@peti fixed, sorry for the delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The Haskell
lzmalibrary refuses to build, complaining that HUnit and QuickCheck are outside of the given version bounds.Things done
One option would be to disable the unit tests, but the tests pass just fine with the versions in nixpkgs, so I just patched the cabal file to loosen the bounds.
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)