cloning a Mojo::Promise object was never really necessary

mojolicious · Jan 2, 2018 · cde3711 · cde3711
1 parent 2805295
commit cde3711
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/Changes b/Changes
@@ -2,6 +2,8 @@
 7.60  2018-01-02
   - Deprecated use of Mojo::Promise::all and Mojo::Promise::race as instance
     methods.
+  - Improved all and race methods in Mojo::Promise to be able to handle
+    arbitrary then-ables.
   - Improved number detection in Mojo::JSON with a workaround for an upcoming
     breaking change in Perl 5.28. (haarg)
   - Improved HTML Living Standard compliance of Mojo::DOM::HTML.

diff --git a/lib/Mojo/Promise.pm b/lib/Mojo/Promise.pm
@@ -15,7 +15,7 @@ sub all {
     and deprecated 'Use of Mojo::Promise::all as instance method is DEPRECATED'
     if ref $class;
 
-  my $all = $promises[0]->_clone;
+  my $all = $class->new;
 
   my $results   = [];
   my $remaining = scalar @promises;
@@ -54,7 +54,7 @@ sub race {
     and deprecated 'Use of Mojo::Promise::race as instance method is DEPRECATED'
     if ref $class;
 
-  my $new = $promises[0]->_clone;
+  my $new = $class->new;
   $_->then(sub { $new->resolve(@_) }, sub { $new->reject(@_) }) for @promises;
 
   return $new;