Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert doc reference from "rake" to "rails" #2431

Merged
merged 1 commit into from Dec 31, 2017
Merged

Convert doc reference from "rake" to "rails" #2431

merged 1 commit into from Dec 31, 2017

Conversation

seanprashad
Copy link
Contributor

@seanprashad seanprashad commented Dec 29, 2017

馃帺 What? Why?

This PR updates documentation to reference rails instead of rake commands for tasks inside the generated app.

馃搶 Related Issues

馃搵 Subtasks

  • N/A

馃摲 Screenshots (optional)

  • N/A

馃懟 GIF

  • N/A

@seanprashad seanprashad changed the title Convert doc references from rake to rails Convert doc references from "rake" to "rails" Dec 29, 2017
@codecov
Copy link

codecov bot commented Dec 29, 2017

Codecov Report

Merging #2431 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2431   +/-   ##
=======================================
  Coverage   98.68%   98.68%           
=======================================
  Files        1294     1294           
  Lines       30172    30172           
=======================================
  Hits        29775    29775           
  Misses        397      397

@deivid-rodriguez
Copy link
Contributor

Hi @seanprashad, thanks so much for helping out with this!

We probably failed to explain the issue correctly. We need to update the documentation for tasks inside generated applications. The tasks run from the decidim root folder still need to be run via rake, since the decidim repo itself is not a Rails application and thus the rails command is not available.

That all means the only change we actually want to keep would be the one in decidim-dev/README.md, and that one should fix this issue. Could you update the PR? 馃槂

@xabier
Copy link
Contributor

xabier commented Dec 29, 2017

@seanprashad you are more than welcome to move to a more challenging PR next 馃槃

@seanprashad
Copy link
Contributor Author

@deivid-rodriguez PR has been updated! I reverted back the changes in everything but decidim-dev/README.md 馃榿

@deivid-rodriguez
Copy link
Contributor

@seanprashad Almost there but not quite yet! Changes in README.md need to be reverted since bundle exec rails s is correct there. Note that we cd into the application folder before that so those happen in the application folder (and bundle exec rake s does not exist anyways :))

@seanprashad seanprashad changed the title Convert doc references from "rake" to "rails" Convert doc reference from "rake" to "rails" Dec 30, 2017
@seanprashad
Copy link
Contributor Author

@deivid-rodriguez I've updated the PR to fix the other lines that I modified which weren't supposed to be touched 馃榾 ! Please let me know if there is anything else I can do

@deivid-rodriguez deivid-rodriguez merged commit 9135a52 into decidim:master Dec 31, 2017
@deivid-rodriguez
Copy link
Contributor

Nothing else, thanks!!

@seanprashad seanprashad deleted the 2386 branch December 31, 2017 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants