Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backporting meta fixes and from master #32620

Merged
merged 8 commits into from Dec 14, 2017
Merged

Backporting meta fixes and from master #32620

merged 8 commits into from Dec 14, 2017

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Dec 13, 2017 •
edited

Motivation for this change

Includes patches from

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

oxij and others added 8 commits December 12, 2017 19:18
@oxij @grahamc
stdenv/generic/check-meta: fix error message evaluation
cf76a80 
(cherry picked from commit 8ae51ff)
@oxij @grahamc
tree-wide: fix either check-meta or meta attrs of all the packages I …
fcbf6ee 
…evaluate

(cherry picked from commit 1858e89)
@vcunat @grahamc
stdenv checkMeta: throw -> trace
b640ae6 
- tracing seems annoying enough
- we get errors for all packages instead of aborting on the first one
- easier to differentiate from unwanted packages (broken, unfree, etc.)

(cherry picked from commit 76bf375)
@vcunat @grahamc
treewide platform checks: abort -> throw
39b4b8d 
They aren't meant to be critical (uncatchable) errors.
Tested with nix-env + checkMeta:
[ "x86_64-linux" "i686-linux" "x86_64-darwin" "aarch64-linux" ]

(cherry picked from commit 3a110ea)
@grahamc
stdenv: allow specifying a eval issuee handler
ec819b8 
(cherry picked from commit f33a513)
@grahamc
Additional aborts -> throws on platform checks
0bc2abb
@grahamc
additional meta fixes
a268942
@grahamc
whitespace
7d16425
@grahamc
Copy link
Member Author

grahamc commented Dec 13, 2017

cc @vcunat I'd like to merge this in the morning.

@grahamc
Copy link
Member Author

grahamc commented Dec 13, 2017

https://github.com/grahamc/ofborg/pull/16 is now ready once this PR merges.

@jtojnar jtojnar closed this Dec 14, 2017
@jtojnar
Copy link
Contributor

jtojnar commented Dec 14, 2017

Sorry, accidentally deleted release-17.09 branch

@jtojnar jtojnar reopened this Dec 14, 2017
@grahamc grahamc merged commit b1f8548 into NixOS:release-17.09 Dec 14, 2017
@grahamc grahamc deleted the check-meta-17.09 branch December 14, 2017 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@grahamc @jtojnar @GrahamcOfBorg @oxij @vcunat