Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zfs/spl bump to 0.7.4 to fix incompatibility with 4.14 #32634

Merged
merged 2 commits into from Dec 13, 2017
Merged

zfs/spl bump to 0.7.4 to fix incompatibility with 4.14 #32634

merged 2 commits into from Dec 13, 2017

Conversation

clefru
Copy link
Contributor

@clefru clefru commented Dec 13, 2017

Motivation for this change

#31640

Things done

On this:

  • Ran nix-build nixos/tests/installer.nix -A zfsroot

On a private cherry-pick against release-17.09:

  • Booted my machine set to 4.14.3
  • Ran nix-build nixos/tests/installer.nix -A zfsroot (which isn't really exciting as the default kernel on release-17.09 is 4.9)
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@clefru clefru changed the title Zfs bump zfs/spl bump to 0.7.4 to fix incompatability with 4.14 Dec 13, 2017
@clefru clefru changed the title zfs/spl bump to 0.7.4 to fix incompatability with 4.14 zfs/spl bump to 0.7.4 to fix incompatibility with 4.14 Dec 13, 2017
@orivej orivej mentioned this pull request Dec 13, 2017
Closed
13 tasks
@orivej orivej merged commit fc96261 into NixOS:master Dec 13, 2017
@orivej
Copy link
Contributor

orivej commented Dec 13, 2017

Thank you!

@clefru
Copy link
Contributor Author

clefru commented Dec 13, 2017

Thanks for the merge , @orivej! Could you cherry-pick into release-17.09?

@orivej orivej mentioned this pull request Dec 14, 2017
Merged
8 tasks
@orivej orivej added the 9.needs: port to stable A PR needs a backport to the stable release. label Dec 14, 2017
orivej added a commit that referenced this pull request Dec 14, 2017
@orivej
zfs: 0.7.3 -> 0.7.4
942a7f2 
cherry picked from commit fc96261

Merge pull request #32634 from clefru/zfs-bump

zfs/spl bump to 0.7.4 to fix incompatibility with 4.14
@orivej
Copy link
Contributor

orivej commented Dec 14, 2017

Released in 942a7f2

@orivej orivej added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis Awaiting requested review from adisbladis

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clefru @orivej @GrahamcOfBorg