Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minikube: fix wrong path for localkube #32625

Merged
merged 1 commit into from Dec 16, 2017
Merged

Conversation

markus1189
Copy link
Contributor

Motivation for this change

We currently move the localkube binary to /localkube. But minikube expects it to be at /usr/loca/bin/localkube in the systemd unit

Things done

Change the patch, such that it copies the file to the correct destination

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Related issue upstream that will be resolved by this: kubernetes/minikube/issues/2307

@orivej orivej merged commit e002941 into NixOS:master Dec 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants