Revert "[BUGFIX release] fix issue with unchaining ChainNodes"

emberjs · Dec 13, 2017 · e1471e7 · e1471e7
1 parent 997758a
commit e1471e7
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 16 deletions.
diff --git a/packages/ember-metal/lib/chains.js b/packages/ember-metal/lib/chains.js
@@ -209,11 +209,8 @@ class ChainNode {
   remove(path) {
     let paths = this._paths;
     if (paths === undefined) { return; }
-
     if (paths[path] > 0) {
       paths[path]--;
-    } else {
-      return;
     }
 
     let key = firstKey(path);

diff --git a/packages/ember-runtime/tests/system/object/computed_test.js b/packages/ember-runtime/tests/system/object/computed_test.js
@@ -266,16 +266,3 @@ QUnit.test('Calling _super in apply outside the immediate function of a CP gette
 
   ok(emberGet(SubClass.create(), 'foo'), 'FOO', 'super value is fetched');
 });
-
-QUnit.test('observing computed.reads prop and overriding it in create() works', function() {
-  let Obj = EmberObject.extend({
-    name: computed.reads('model.name'),
-    nameDidChange: observer('name', function() {})
-  });
-
-  let obj1 = Obj.create({name: '1'});
-  let obj2 = Obj.create({name: '2'});
-
-  equal(obj1.get('name'), '1');
-  equal(obj2.get('name'), '2');
-});