Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnucash26: 2.6.12 -> 2.6.18-1 #32130

Merged
merged 3 commits into from Nov 28, 2017
Merged

Conversation

mdorman
Copy link
Contributor

@mdorman mdorman commented Nov 28, 2017

Motivation for this change

Updated version, as well as a patch that fixes a known-problematic test (per: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=876306) that manifests itself in current builds.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

mdorman and others added 3 commits November 28, 2017 23:44
Patch taken from the upstream repository, should be fixed in next
released version.

This did require moving the invocation of `patchShebangs` from
`patchPhase` to `postpatch`, but this seems consistent with at least
some other packages.
This version still requires the prior test fix.
@orivej orivej merged commit 72a53d5 into NixOS:master Nov 28, 2017
@mdorman mdorman deleted the gnucash-fix-and-update branch November 29, 2017 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants