Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve install documentation #639

Merged
merged 7 commits into from Dec 14, 2017
Merged

Improve install documentation #639

merged 7 commits into from Dec 14, 2017

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Nov 27, 2017

Fixes #592

@Spongy
Copy link

Spongy commented Nov 27, 2017

@phit
Copy link
Contributor

phit commented Nov 27, 2017

Mh, while you are at this: I wrote this a while ago because people kept trying to match forge and sponge exactly https://gist.github.com/phit/d097a5a4e7172e6c1e4a7616596bc7ce (for the example in source/server/getting-started/implementations/spongeforge.rst)

32-bit vs. 64-bit
~~~~~~~~~~~~~~~~~

If your computer supports it, you should use 64-bit versions of Java whenever possible. The Java installers from the
linked website should detect whether your computer is ready for 64-bit.
`this website <https://java.com/en/download/>`__ should detect whether your computer is ready for 64-bit.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about that, there is the selection, but it does not really help you with selecting 32 or 64 bit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some browsers can handle the auto-detection, and some (eg. Pale Moon) cannot. The manual downloads page is a good place to make sure you get a 64-bit version, but you can also have multiple versions of Java installed so it's no guarantee that it'll be the one used by software. The Java control panel will give you the info in Windows, but I'm not sure about Mac or Linux systems.

@ST-DDT
Copy link
Member Author

ST-DDT commented Nov 27, 2017

@phit Like this? 3b52925

@phit
Copy link
Contributor

phit commented Nov 27, 2017

yeah, feel free to proofread and improve on that, I just wanted to make it clearer that you don't always have to use the exact version and avoid people asking when SpongeForge will get updated to Forge XXXX

problem. However, SpongeForge needs to access, among other things, internal parts of Forge, which most mods
shouldn’t be touching, let alone modifying as Sponge does. Since Forge is free to change their internal code
whenever they want to, its normal guarantee of backwards-compatibility doesn’t apply to SpongeForge. Feel free to
use more recent versions of Forge, than the one used for SpongeForge, but we can't always garantee compatibility.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guarantee

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blame me

| ``MCVersion`` | The Minecraft version. Only clients compatible with this version can connect. |
+----------------------+-----------------------------------------------------------------------------------------------+
| ``ForgeBuildId`` | The build number of Forge this file is built for. Preferably your server should run this exact|
| | version of Forge. Which is the last part of Forge's version string. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be one sentence, and made a bit clearer. ie. Preferably your server should run this exact version of Forge (which can be identified in the last part of Forge's version string).


.. warning::

When investigating crash issues, you can freely use a newer versions of Forge than listed on the SpongeForge Jar.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some plural problems here. The "a" is not needed in this sentence. However, the next sentence should refer to a singular matching version, and I'd refer to "a version mismatch" (there may not be one).

@ST-DDT
Copy link
Member Author

ST-DDT commented Nov 29, 2017

  • Mention Sponge needs Java 8.0.40
  • Link to how to install Java / config JRE
  • Mention alternative download section
  • Automatic download page

@ST-DDT
Copy link
Member Author

ST-DDT commented Nov 30, 2017

@Inscrutable In #592 (comment) you mentioned an alternative minecraft download page for a version without Java embedded. Are you referring to that page: https://minecraft.net/en-us/download/alternative ?

@kinggoesgaming
Copy link

Mention that sponge only work with java 8 not 9

@ST-DDT
Copy link
Member Author

ST-DDT commented Dec 2, 2017

I did that here or do you want it elsewhere as well?

@ST-DDT ST-DDT added the needs review The submission is ready and needs to be reviewed label Dec 3, 2017
@ST-DDT
Copy link
Member Author

ST-DDT commented Dec 3, 2017

Ready for review.

Copy link
Member

@Inscrutable Inscrutable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is almost finished, thanks again for fixing up these muddy issues.

@@ -30,10 +46,11 @@ SpongeVanilla only works as a dedicated server.

.. warning::

Don't double-click the ``.jar`` file!
Don't double-click the ``.jar`` file! As it will start the server without a window to control it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be one sentence.

32-bit vs. 64-bit
~~~~~~~~~~~~~~~~~

If your computer supports it, you should use 64-bit versions of Java whenever possible. The Java installers from the
linked website should detect whether your computer is ready for 64-bit.
`this website <https://java.com/en/download/>`__ should detect whether your computer is ready for 64-bit.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some browsers can handle the auto-detection, and some (eg. Pale Moon) cannot. The manual downloads page is a good place to make sure you get a 64-bit version, but you can also have multiple versions of Java installed so it's no guarantee that it'll be the one used by software. The Java control panel will give you the info in Windows, but I'm not sure about Mac or Linux systems.

@Inscrutable Inscrutable merged commit b7761b0 into stable Dec 14, 2017
@Inscrutable Inscrutable removed the needs review The submission is ready and needs to be reviewed label Dec 14, 2017
@ST-DDT ST-DDT deleted the fixes/install branch December 14, 2017 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants