Add pythonPackages.salmon and dependencies #32097
Conversation
|
|
||
| buildPythonPackage rec { | ||
| name = "${pname}-${version}"; | ||
| pname = "dnspython"; |
There was a problem hiding this comment.
this is a duplicate of the attribute dns
There was a problem hiding this comment.
Nice, good to know, thanks. But why is it named dns instead of dnspython which is the "official" name of the package? I think this should be fixed. Maybe offer both names with dnspython = dns?
There was a problem hiding this comment.
History. It was simply called dns because it was in an expression containing only Python packages. So why duplicate the fact that it its a Python package?
We could introduce an alias and then with 18.09 remove the dns attribute.
There was a problem hiding this comment.
I recommend using always the name from pypi, i.e. dnspython, as this is unique. Provided namespaces are not unique.
There was a problem hiding this comment.
@sebix that's also the current guideline in python-packages.nix
| @@ -304,6 +308,8 @@ in { | |||
|
|
|||
| rhpl = if !isPy3k then callPackage ../development/python-modules/rhpl {} else throw "rhpl not supported for interpreter ${python.executable}"; | |||
|
|
|||
| salmon = callPackage ../development/python-modules/salmon { }; | |||
There was a problem hiding this comment.
This is an application and should therefore be called directly from all-packages.nix, and not via python-packages.nix.
There was a problem hiding this comment.
Hmm.. I think I disagree on this. Salmon is to email what Django is to websites. So, I think it should be a package instead of an application. In order to use Salmon, one must write Python modules to define configuration and handlers and apps. Salmon isn't an application that you just launch and it would work on its own. I think we should support both Python 2 and Python 3. I don't see any reason to make Salmon an app, is there some benefit in doing that?
|
@jluttine status? |
|
Working on it some day soon.
…On December 5, 2017 9:37:31 PM GMT+02:00, Frederik Rietdijk ***@***.***> wrote:
@jluttine status?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#32097 (comment)
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
jluttine
force-pushed
the
add-python-salmon
branch
from
cfe0461
to
f74f5ed
Compare
|
@FRidh Done. I just used |
Motivation for this change
Add Python package salmon and its dependencies.
I wasn't able to run the tests for dnspython successfully. I got the following errors: rthalley/dnspython#289. If anyone has ideas how to fix those, I could try to fix. For now, I just skipped the tests (although not all tests failed).
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)