Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eolie: init at 0.9.14 #32092

Merged
merged 1 commit into from Dec 29, 2017
Merged

eolie: init at 0.9.14 #32092

merged 1 commit into from Dec 29, 2017

Conversation

samdroid-apps
Copy link
Contributor

Motivation for this change

Add this cool web browser: https://gnumdk.github.io/eolie-web/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS - N/A
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

python36Packages.pycrypto
python36Packages.requests

wrapGAppsHook
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would also go to nativeBuildInputs.

@samdroid-apps
Copy link
Contributor Author

Thanks for the review @Mic92 - I forced pushed a fix that:

  • Moves build tools to nativeBuildInputs
  • Updates to 0.9.14 (the latest upstream release)

@samdroid-apps samdroid-apps changed the title eolie: init at 0.9.13 eolie: init at 0.9.14 Dec 1, 2017
@Mic92
Copy link
Member

Mic92 commented Dec 2, 2017

There seems to be a library still missing:

$ eolie
Traceback (most recent call last):
  File "/nix/store/knlpysaddcr8xhrhncif1ssmk2czyinx-eolie-0.9.14/bin/.eolie-wrapped", line 24, in <module>
    from eolie.application import Application
  File "/nix/store/knlpysaddcr8xhrhncif1ssmk2czyinx-eolie-0.9.14/lib/python3.6/site-packages/eolie/application.py", line 17, in <module>
    gi.require_version('Secret', '1')
  File "/nix/store/59dbjmwa3asrhmwv3nbw7qpr2ssmlykm-python3.6-pygobject-3.24.1/lib/python3.6/site-packages/gi/__init__.py", line 118, in require_version
    raise ValueError('Namespace %s not available' % namespace)
ValueError: Namespace Secret not available

@samdroid-apps
Copy link
Contributor Author

Thanks @Mic92 for the review; sorry for taking so long to get back.

I've force pushed a fix that:

@lukateras
Copy link
Member

@GrahamcOfBorg build eolie

@lukateras
Copy link
Member

@GrahamcOfBorg eval

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

Package ‘eolie-0.9.16’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/applications/networking/browsers/eolie/default.nix:82 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

glibPreFixupPhase
post-installation fixup
Wrapping program /nix/store/jq3p2wzcqx26zyqgh844gb1864lfc8rh-eolie-0.9.16/bin/eolie
Wrapping program /nix/store/jq3p2wzcqx26zyqgh844gb1864lfc8rh-eolie-0.9.16/libexec/eolie-sp
shrinking RPATHs of ELF executables and libraries in /nix/store/jq3p2wzcqx26zyqgh844gb1864lfc8rh-eolie-0.9.16
shrinking /nix/store/jq3p2wzcqx26zyqgh844gb1864lfc8rh-eolie-0.9.16/lib/eolie/webkitextension/libpythonloader.so
stripping (with flags -S) in /nix/store/jq3p2wzcqx26zyqgh844gb1864lfc8rh-eolie-0.9.16/lib  /nix/store/jq3p2wzcqx26zyqgh844gb1864lfc8rh-eolie-0.9.16/libexec  /nix/store/jq3p2wzcqx26zyqgh844gb1864lfc8rh-eolie-0.9.16/bin 
patching script interpreter paths in /nix/store/jq3p2wzcqx26zyqgh844gb1864lfc8rh-eolie-0.9.16
checking for references to /tmp/nix-build-eolie-0.9.16.drv-0 in /nix/store/jq3p2wzcqx26zyqgh844gb1864lfc8rh-eolie-0.9.16...
/nix/store/jq3p2wzcqx26zyqgh844gb1864lfc8rh-eolie-0.9.16

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

glibPreFixupPhase
post-installation fixup
Wrapping program /nix/store/xvwp887hwhqlrm4n3gs4ks38q72rlcgq-eolie-0.9.16/bin/eolie
Wrapping program /nix/store/xvwp887hwhqlrm4n3gs4ks38q72rlcgq-eolie-0.9.16/libexec/eolie-sp
shrinking RPATHs of ELF executables and libraries in /nix/store/xvwp887hwhqlrm4n3gs4ks38q72rlcgq-eolie-0.9.16
shrinking /nix/store/xvwp887hwhqlrm4n3gs4ks38q72rlcgq-eolie-0.9.16/lib/eolie/webkitextension/libpythonloader.so
stripping (with flags -S) in /nix/store/xvwp887hwhqlrm4n3gs4ks38q72rlcgq-eolie-0.9.16/lib  /nix/store/xvwp887hwhqlrm4n3gs4ks38q72rlcgq-eolie-0.9.16/libexec  /nix/store/xvwp887hwhqlrm4n3gs4ks38q72rlcgq-eolie-0.9.16/bin
patching script interpreter paths in /nix/store/xvwp887hwhqlrm4n3gs4ks38q72rlcgq-eolie-0.9.16
checking for references to /build in /nix/store/xvwp887hwhqlrm4n3gs4ks38q72rlcgq-eolie-0.9.16...
/nix/store/xvwp887hwhqlrm4n3gs4ks38q72rlcgq-eolie-0.9.16

Copy link
Member

@lukateras lukateras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screenshot_2017-12-29_06-59-47

I had to add glib_networking for TLS connections. I'll add it and push Eolie to master. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants