Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentx: init at 2.2.0 #32095

Merged
merged 1 commit into from Mar 2, 2018
Merged

opentx: init at 2.2.0 #32095

merged 1 commit into from Mar 2, 2018

Conversation

elitak
Copy link
Contributor

@elitak elitak commented Nov 27, 2017

Motivation for this change

Personal; was pretty easy to get working.

Things done

Tested fairly briefly. All UI stuff works, dfu-util path, didn't try avrdude path. Writing to sdcard doesnt work without manually mounting the volumes with write access.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@adisbladis
Copy link
Member

@GrahamcOfBorg build opentx

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-linux

  /nix/store/4dz5lyayvg2vl2hs5s9y3qypbb9v2wdv-qt-5.9.1/lib/cmake/Qt5Gui/Qt5Gui_QICNSPlugin.cmake:4 (_populate_Gui_plugin_properties)
  /nix/store/4dz5lyayvg2vl2hs5s9y3qypbb9v2wdv-qt-5.9.1/lib/cmake/Qt5Gui/Qt5GuiConfig.cmake:164 (include)
  /nix/store/4dz5lyayvg2vl2hs5s9y3qypbb9v2wdv-qt-5.9.1/lib/cmake/Qt5Widgets/Qt5WidgetsConfig.cmake:87 (find_package)
  CMakeLists.txt:66 (find_package)


-- Configuring incomplete, errors occurred!
See also "/tmp/nix-build-opentx-2.2.0.drv-0/source/build/CMakeFiles/CMakeOutput.log".
builder for ‘/nix/store/jcm75s1nvglf3mi87xg0gw8p06qh75ik-opentx-2.2.0.drv’ failed with exit code 1
error: build of ‘/nix/store/jcm75s1nvglf3mi87xg0gw8p06qh75ik-opentx-2.2.0.drv’ failed

@elitak
Copy link
Contributor Author

elitak commented Nov 27, 2017

Is there a problem with Qt5 on master? My changeset builds fine on a checkout of master@{3 weeks ago}.

buildInputs = [
cmake gcc-arm-embedded
python python.pkgs.pyqt4
qt5.full SDL gmock
Copy link
Member

@Mic92 Mic92 Nov 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmake should be in nativeBuildInputs. Where is pyqt4 used? Just adding it to buildInputs will usually not make it available at runtime.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something in the cmakelist was checking for it, so I just added it and the warning went away. Any idea why I get this qt lib file-not-found build error on the newer master branch?

Copy link
Member

@Mic92 Mic92 Nov 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does cmake add a pyqt4 reference in its build or is this information thrown away?

Copy link
Contributor Author

@elitak elitak Nov 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's needed:

-- Build files have been written to: /tmp/nix-build-opentx-2.2.0.drv-2/opentx-2.2.0-src/build
building
build flags: -j8 -l8 SHELL=/nix/store/h404wfcz8rzzlq8vr4z7plcijwzfci72-bash-4.4-p12/bin/bash
Scanning dependencies of target taranis_xbm
[  0%] Generating sticks.lbm
Traceback (most recent call last):
  File "/tmp/nix-build-opentx-2.2.0.drv-2/opentx-2.2.0-src/radio/util/img2lbm.py", line 9, in <module>
    from PyQt4 import Qt, QtGui
ImportError: No module named PyQt4
make[2]: *** [radio/src/bitmaps/212x64/CMakeFiles/taranis_xbm.dir/build.make:61: radio/src/bitmaps/212x64/sticks.lbm] Error 1
make[1]: *** [CMakeFiles/Makefile2:520: radio/src/bitmaps/212x64/CMakeFiles/taranis_xbm.dir/all] Error 2
make: *** [Makefile:152: all] Error 2
builder for ‘/nix/store/fafad88azc5mh0xdd9by1sflglws6hdn-opentx-2.2.0.drv’ failed with exit code 2
error: build of ‘/nix/store/fafad88azc5mh0xdd9by1sflglws6hdn-opentx-2.2.0.drv’ failed

I still need help with the missing Qt5 files error.

@elitak
Copy link
Contributor Author

elitak commented Feb 16, 2018

I fixed the Qt5 issue. This is ready for merge now.

@Mic92
Copy link
Member

Mic92 commented Feb 26, 2018

@GrahamcOfBorg build opentx

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘avrdude-6.3’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/development/tools/misc/avrdude/default.nix:22 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

[ 41%] Built target opentx-x9d+-simulator
[ 41%] Linking CXX static library libshared.a
[ 41%] Built target shared
[ 41%] Linking CXX static library libsimulation.a
[ 41%] Built target simulation
[ 41%] Linking CXX static library libqcustomplot.a
[ 41%] Built target qcustomplot
make: *** [Makefile:152: all] Error 2
builder for '/nix/store/6qiv8n9ggjiv0d79ymih3yhl0h6106li-opentx-2.2.1.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/6qiv8n9ggjiv0d79ymih3yhl0h6106li-opentx-2.2.1.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/2iblisxy1vr7vzjx1l3l54nv22dr9sm8-opentx-2.2.1
shrinking /nix/store/2iblisxy1vr7vzjx1l3l54nv22dr9sm8-opentx-2.2.1/bin/simulator22
shrinking /nix/store/2iblisxy1vr7vzjx1l3l54nv22dr9sm8-opentx-2.2.1/bin/companion22
shrinking /nix/store/2iblisxy1vr7vzjx1l3l54nv22dr9sm8-opentx-2.2.1/lib/companion22/libopentx-x9d+-simulator.so
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/2iblisxy1vr7vzjx1l3l54nv22dr9sm8-opentx-2.2.1/lib  /nix/store/2iblisxy1vr7vzjx1l3l54nv22dr9sm8-opentx-2.2.1/bin 
patching script interpreter paths in /nix/store/2iblisxy1vr7vzjx1l3l54nv22dr9sm8-opentx-2.2.1
checking for references to /tmp/nix-build-opentx-2.2.1.drv-0 in /nix/store/2iblisxy1vr7vzjx1l3l54nv22dr9sm8-opentx-2.2.1...
postPatchMkspecs
/nix/store/2iblisxy1vr7vzjx1l3l54nv22dr9sm8-opentx-2.2.1

@elitak
Copy link
Contributor Author

elitak commented Mar 1, 2018

@GrahamcOfBorg build opentx

1 similar comment
@Mic92
Copy link
Member

Mic92 commented Mar 1, 2018

@GrahamcOfBorg build opentx

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘opentx-2.2.1’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/applications/misc/opentx/default.nix:46 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Package ‘opentx-2.2.1’ in /var/lib/gc-of-borg/nix-test-rs-19/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-19/pkgs/applications/misc/opentx/default.nix:46 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/axm0f1ks8ch94mgpdc4nfg8lk6qbb1l0-opentx-2.2.1
shrinking /nix/store/axm0f1ks8ch94mgpdc4nfg8lk6qbb1l0-opentx-2.2.1/bin/companion22
shrinking /nix/store/axm0f1ks8ch94mgpdc4nfg8lk6qbb1l0-opentx-2.2.1/bin/simulator22
shrinking /nix/store/axm0f1ks8ch94mgpdc4nfg8lk6qbb1l0-opentx-2.2.1/lib/companion22/libopentx-x9d+-simulator.so
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/axm0f1ks8ch94mgpdc4nfg8lk6qbb1l0-opentx-2.2.1/lib  /nix/store/axm0f1ks8ch94mgpdc4nfg8lk6qbb1l0-opentx-2.2.1/bin 
patching script interpreter paths in /nix/store/axm0f1ks8ch94mgpdc4nfg8lk6qbb1l0-opentx-2.2.1
checking for references to /tmp/nix-build-opentx-2.2.1.drv-0 in /nix/store/axm0f1ks8ch94mgpdc4nfg8lk6qbb1l0-opentx-2.2.1...
postPatchMkspecs
/nix/store/axm0f1ks8ch94mgpdc4nfg8lk6qbb1l0-opentx-2.2.1

This does not yet cross-compile the firmware images.
@elitak
Copy link
Contributor Author

elitak commented Mar 2, 2018

@Mic92 I limited the meta.platforms to i686 and x86_64 linux, so now there shouldn't be any broken builds. Commit?

@Mic92 Mic92 merged commit e0b5bdd into NixOS:master Mar 2, 2018
@Mic92
Copy link
Member

Mic92 commented Mar 2, 2018

Thanks!

@elitak elitak deleted the opentx branch December 29, 2018 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants