-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
opentx: init at 2.2.0 #32095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opentx: init at 2.2.0 #32095
Conversation
@GrahamcOfBorg build opentx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failure for system: x86_64-linux
/nix/store/4dz5lyayvg2vl2hs5s9y3qypbb9v2wdv-qt-5.9.1/lib/cmake/Qt5Gui/Qt5Gui_QICNSPlugin.cmake:4 (_populate_Gui_plugin_properties)
/nix/store/4dz5lyayvg2vl2hs5s9y3qypbb9v2wdv-qt-5.9.1/lib/cmake/Qt5Gui/Qt5GuiConfig.cmake:164 (include)
/nix/store/4dz5lyayvg2vl2hs5s9y3qypbb9v2wdv-qt-5.9.1/lib/cmake/Qt5Widgets/Qt5WidgetsConfig.cmake:87 (find_package)
CMakeLists.txt:66 (find_package)
-- Configuring incomplete, errors occurred!
See also "/tmp/nix-build-opentx-2.2.0.drv-0/source/build/CMakeFiles/CMakeOutput.log".
builder for ‘/nix/store/jcm75s1nvglf3mi87xg0gw8p06qh75ik-opentx-2.2.0.drv’ failed with exit code 1
error: build of ‘/nix/store/jcm75s1nvglf3mi87xg0gw8p06qh75ik-opentx-2.2.0.drv’ failed
Is there a problem with Qt5 on master? My changeset builds fine on a checkout of master@{3 weeks ago}. |
buildInputs = [ | ||
cmake gcc-arm-embedded | ||
python python.pkgs.pyqt4 | ||
qt5.full SDL gmock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cmake should be in nativeBuildInputs
. Where is pyqt4 used? Just adding it to buildInputs
will usually not make it available at runtime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something in the cmakelist was checking for it, so I just added it and the warning went away. Any idea why I get this qt lib file-not-found build error on the newer master branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does cmake add a pyqt4 reference in its build or is this information thrown away?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's needed:
-- Build files have been written to: /tmp/nix-build-opentx-2.2.0.drv-2/opentx-2.2.0-src/build
building
build flags: -j8 -l8 SHELL=/nix/store/h404wfcz8rzzlq8vr4z7plcijwzfci72-bash-4.4-p12/bin/bash
Scanning dependencies of target taranis_xbm
[ 0%] Generating sticks.lbm
Traceback (most recent call last):
File "/tmp/nix-build-opentx-2.2.0.drv-2/opentx-2.2.0-src/radio/util/img2lbm.py", line 9, in <module>
from PyQt4 import Qt, QtGui
ImportError: No module named PyQt4
make[2]: *** [radio/src/bitmaps/212x64/CMakeFiles/taranis_xbm.dir/build.make:61: radio/src/bitmaps/212x64/sticks.lbm] Error 1
make[1]: *** [CMakeFiles/Makefile2:520: radio/src/bitmaps/212x64/CMakeFiles/taranis_xbm.dir/all] Error 2
make: *** [Makefile:152: all] Error 2
builder for ‘/nix/store/fafad88azc5mh0xdd9by1sflglws6hdn-opentx-2.2.0.drv’ failed with exit code 2
error: build of ‘/nix/store/fafad88azc5mh0xdd9by1sflglws6hdn-opentx-2.2.0.drv’ failed
I still need help with the missing Qt5 files error.
I fixed the Qt5 issue. This is ready for merge now. |
@GrahamcOfBorg build opentx |
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
Failure on aarch64-linux (full log) Partial log (click to expand)
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
@GrahamcOfBorg build opentx |
1 similar comment
@GrahamcOfBorg build opentx |
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
Failure on aarch64-linux (full log) Partial log (click to expand)
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
This does not yet cross-compile the firmware images.
@Mic92 I limited the |
Thanks! |
Motivation for this change
Personal; was pretty easy to get working.
Things done
Tested fairly briefly. All UI stuff works, dfu-util path, didn't try avrdude path. Writing to sdcard doesnt work without manually mounting the volumes with write access.
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)