treewide: Use targetPrefix instead of prefix for platform name prefixes
#32098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
force-pushed
the
binPrefix
branch
from
cf1b5d5
to
b99a89b
Compare
Ericson2314
added
the
6.topic: cross-compilation
Ericson2314
requested review from
copumpkin,
orivej and
edolstra
and removed request for
orivej and
edolstra
…efixes Certain tools, e.g. compilers, are customarily prefixed with the name of their target platform so that multiple builds can be used at once without clobbering each other on the PATH. I was using identifiers named `prefix` for this purpose, but that conflicts with the standard use of `prefix` to mean the directory where something is installed. To avoid conflict and confusion, I renamed those to `targetPrefix`.
Ericson2314
force-pushed
the
binPrefix
branch
from
b99a89b
to
e755a8a
Compare
Ericson2314
changed the title
binPrefix instead of prefix for platform name prefixestargetPrefix instead of prefix for platform name prefixes
orivej
approved these changes
Nov 27, 2017
Ericson2314
added a commit
that referenced
this pull request
Nov 27, 2017
I forgot to sed some files in #32098.
Ericson2314
moved this from Solved by big PR
to Needed for binutils-wrapper
in Cross compilation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Certain tools, e.g. compilers, are customarily prefixed with the name of their target platform so that multiple builds can be used at once without clobbering each other on the PATH. I was using identifiers named
prefixfor this purpose, but that conflicts with the standard use ofprefixto mean the directory where something is installed. To avoid conflict and confusion, I renamed those tobinPrefix.Things done
No hashes were changed the first time. Then I switched from
binPrefixtotargetPrefixat @orivej's suggestion. But it was a safe sed, so this still must be fine.build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)