New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bintools-wrapper: symlink all programs that do not need wrapping #33110
Conversation
cc @Ericson2314 |
Thanks for the contribution! But how does this help, exactly? the bintools-wrapper should add the unwrapped derivation behind it to the path behind it, I believe. |
When cross-compiling neither bintools is added directly to the path as far as I can see:
Instead they the GCC-wrapper symlinks to executables from binutils-wrapper (as far as I can understand things). Presumably this is why the assembler is already symlinked from the plain binutils to the wrapped version ? |
Hmm the
In bintools-wrapper's setup hook should be doing that. |
@Ericson2314: now these PRs have been merged. |
Good catch. It was indeed not needed, but I do want to take the exlanded listof programs to make env vars in bintool-wrapper's setup hook. |
Motivation for this change
Cross compilation for mingw32 targets is broken earlier than before the binutil-wrapping. This gets us back to where we were ~6weeks ago.
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)