Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testssl: refactor and improve expression #33105

Merged
merged 1 commit into from Jan 1, 2018
Merged

Conversation

etu
Copy link
Contributor

@etu etu commented Dec 27, 2017

Motivation for this change

This just improves readability of the expression.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@adisbladis
Copy link
Member

@GrahamcOfBorg build testssl

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

building
no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/sy8kg0mkar0p7xnx23l384shjim36fqs-testssl.sh-2.9.5-1
stripping (with flags -S) in /nix/store/sy8kg0mkar0p7xnx23l384shjim36fqs-testssl.sh-2.9.5-1/bin 
patching script interpreter paths in /nix/store/sy8kg0mkar0p7xnx23l384shjim36fqs-testssl.sh-2.9.5-1
/nix/store/sy8kg0mkar0p7xnx23l384shjim36fqs-testssl.sh-2.9.5-1/bin/testssl.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/65l6hr8snf4v823f974k97jc65i7bhvf-bash-4.4-p12/bin/bash"
checking for references to /tmp/nix-build-testssl.sh-2.9.5-1.drv-0 in /nix/store/sy8kg0mkar0p7xnx23l384shjim36fqs-testssl.sh-2.9.5-1...
/nix/store/sy8kg0mkar0p7xnx23l384shjim36fqs-testssl.sh-2.9.5-1

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

building
no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/fh5k22hjmszx626907jpqbmq7i3rvshc-testssl.sh-2.9.5-1
stripping (with flags -S) in /nix/store/fh5k22hjmszx626907jpqbmq7i3rvshc-testssl.sh-2.9.5-1/bin
patching script interpreter paths in /nix/store/fh5k22hjmszx626907jpqbmq7i3rvshc-testssl.sh-2.9.5-1
/nix/store/fh5k22hjmszx626907jpqbmq7i3rvshc-testssl.sh-2.9.5-1/bin/testssl.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/cvbdn77044rj012x7xfv1dj2dv9zqkcd-bash-4.4-p12/bin/bash"
checking for references to /build in /nix/store/fh5k22hjmszx626907jpqbmq7i3rvshc-testssl.sh-2.9.5-1...
/nix/store/fh5k22hjmszx626907jpqbmq7i3rvshc-testssl.sh-2.9.5-1

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-darwin

configuring
no configure script, doing nothing
building
no Makefile, doing nothing
installing
post-installation fixup
stripping (with flags -S) in /nix/store/xa53nq9h69ynk2blc55vsw6zlzhp5bc5-testssl.sh-2.9.5-1/bin 
patching script interpreter paths in /nix/store/xa53nq9h69ynk2blc55vsw6zlzhp5bc5-testssl.sh-2.9.5-1
/nix/store/xa53nq9h69ynk2blc55vsw6zlzhp5bc5-testssl.sh-2.9.5-1/bin/testssl.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/hiv85an0qyzj6ps88f5pvkbbdj8238nj-bash-4.4-p12/bin/bash"
/nix/store/xa53nq9h69ynk2blc55vsw6zlzhp5bc5-testssl.sh-2.9.5-1

@adisbladis adisbladis merged commit 4fe3297 into NixOS:master Jan 1, 2018
@etu etu deleted the testssl-fixups branch January 1, 2018 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants