Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change from bash to sh #5468

Merged
merged 1 commit into from Jan 2, 2018
Merged

Change from bash to sh #5468

merged 1 commit into from Jan 2, 2018

Conversation

j8r
Copy link
Contributor

@j8r j8r commented Dec 27, 2017

  • Removes bash as a dependency
  • Better compliance to POSIX

@j8r j8r force-pushed the shell-cleanups branch 4 times, most recently from 6e76df6 to 2726406 Compare December 27, 2017 19:27
@j8r
Change from bash to sh
2726406 
* Removes bash as a dependency
* Better compliance to POSIX
@RX14 RX14 merged commit 80f94f3 into crystal-lang:master Jan 2, 2018
@RX14 RX14 added this to the Next milestone Jan 2, 2018
@j8r j8r deleted the shell-cleanups branch January 4, 2018 09:22
lukeasrodgers pushed a commit to lukeasrodgers/crystal that referenced this pull request Jan 7, 2018
@j8r @lukeasrodgers
Change from bash to sh (crystal-lang#5468)
041ea86 
* Removes bash as a dependency
* Better compliance to POSIX
bcardiff added a commit to bcardiff/crystal-dist that referenced this pull request Mar 10, 2018
@bcardiff
Change from bash to sh in release docker image
dc5dad3 
Ref: crystal-lang/crystal#5468
bcardiff added a commit to crystal-lang/distribution-scripts that referenced this pull request Apr 27, 2018
@bcardiff
Change from bash to sh in nightly docker image
58834cd 
Ref: crystal-lang/crystal#5468
bcardiff added a commit to crystal-lang/distribution-scripts that referenced this pull request May 21, 2018
@bcardiff
Fix file naming fixes and fix shell to be used in docker images (#8)
517fb02 
* Add -linux- suffix to .tar.* generated files

* Change from `bash` to `sh` in nightly docker image

Ref: crystal-lang/crystal#5468
@bcardiff bcardiff mentioned this pull request Jun 10, 2018
Merged
bcardiff added a commit to crystal-lang/crystal-dist that referenced this pull request Jun 15, 2018
@bcardiff
Change from bash to sh in release docker image (#4)
88f3037 
Ref: crystal-lang/crystal#5468
@jwoertink jwoertink mentioned this pull request Jul 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asterite asterite asterite approved these changes

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
kind:refactor topic:infrastructure
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@j8r @asterite @RX14