Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

electrum-ltc: 2.6.4.2 -> 2.9.3.1 #33104

Merged
merged 1 commit into from Dec 30, 2017
Merged

electrum-ltc: 2.6.4.2 -> 2.9.3.1 #33104

merged 1 commit into from Dec 30, 2017

Conversation

kim0
Copy link
Contributor

@kim0 kim0 commented Dec 27, 2017 •
edited

Motivation for this change

Updated version, added a needed python dependency

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@kim0
Copy link
Contributor Author

kim0 commented Dec 27, 2017

@asymmetric .. Please check & kindly merge. Thanks

@asymmetric
Copy link
Contributor

asymmetric commented Dec 27, 2017 •
edited

@kim0 remember to reuse the template text when you open a PR , with all the relevant checkboxes checked.

Also, the commit message doesn't conform to the guidelines, please read them and make adjustments.

@kim0
Copy link
Contributor Author

kim0 commented Dec 27, 2017

@asymmetric .. Thanks, frankly today is my first day touching nix, and some of those checks were way above my head :) I tested with nix-build locally on a linux server, and it worked.

@asymmetric
Copy link
Contributor

asymmetric commented Dec 27, 2017 •
edited

No worries, just:

  • insert the template in the PR description
  • change the PR's title according to the guidelines, i.e. electrum-ltc: 2.6.4.2 -> 2.9.3.1
  • change the commit message according to the guidelines, same as above

@kim0 kim0 changed the title Upgrade electrum-ltc to 2.9.3.1 electrum-ltc: 2.6.4.2 -> 2.9.3.1 Dec 27, 2017
@kim0
Copy link
Contributor Author

kim0 commented Dec 27, 2017

@asymmetric .. Hope it's better now. Thanks

asymmetric
asymmetric requested changes Dec 27, 2017
View reviewed changes
Copy link
Contributor

@asymmetric asymmetric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also seems there's a requirement on PySocks.

pkgs/applications/misc/electrum-ltc/default.nix
@@ -23,6 +23,7 @@ python2Packages.buildPythonApplication rec {
protobuf
dnspython
jsonrpclib
pyaes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like pyaes replaced slowaes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch .. I'll remove slowaes.
wrt PySocks, is there any syntax to define a version (>=1.6.6) .. or should I just list its name and grab latest ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I was interested if there's a way to gpg verify downloads before unpacking. Couldn't find that in the manual

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't specify a version, so you should manually check if the required one is available in nixpkgs, and if it isn't, try to upgrade it there. In this case, the one in nixpkgs is 1.6.6.

I'm not sure if you can GPG verify checksums, you might want to ask in the IRC channel.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed slowaes and added pysocks

@asymmetric
Copy link
Contributor

Do you also get this error when running electrum-ltc?

Exception in thread Thread-6:
Traceback (most recent call last):
  File "/nix/store/hr461qqci171p6k53wwz52ifyp2h9g9l-python-2.7.14/lib/python2.7/threading.py", line 801, in __bootstrap_inner
    self.run()
  File "/nix/store/h0cl51fksvgf64il3zci05ldcn72rck4-electrum-ltc-2.9.3.1/lib/python2.7/site-packages/electrum_ltc/interface.py", line 208, in run
    socket = self.get_socket()
  File "/nix/store/h0cl51fksvgf64il3zci05ldcn72rck4-electrum-ltc-2.9.3.1/lib/python2.7/site-packages/electrum_ltc/interface.py", line 123, in get_socket
    s = self.get_simple_socket()
  File "/nix/store/h0cl51fksvgf64il3zci05ldcn72rck4-electrum-ltc-2.9.3.1/lib/python2.7/site-packages/electrum_ltc/interface.py", line 101, in get_simple_socket
    l = socket.getaddrinfo(self.host, self.port, socket.AF_UNSPEC, socket.SOCK_STREAM)
error: [Errno 16] Device or resource busy

@kim0
Copy link
Contributor Author

kim0 commented Dec 28, 2017

@asymmetric .. I guess it's working fine for me on linux x64

kim0@rttm:~/nixpkgs$ /nix/store/ys37yj8qjd1688406v0hh1zxd3973k3r-electrum-ltc-2.9.3.1/bin/electrum-ltc make_seed
orbit proud latin enjoy kingdom erosion exclude discover evoke sadness hover axis
kim0@rttm:~/nixpkgs$ /nix/store/ys37yj8qjd1688406v0hh1zxd3973k3r-electrum-ltc-2.9.3.1/bin/electrum-ltc version
2.9.3.1

@FRidh FRidh merged commit 9b22100 into NixOS:master Dec 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asymmetric asymmetric asymmetric approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kim0 @asymmetric @FRidh @GrahamcOfBorg @Janik-Haag