Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

palemoon: use upstream recommended options #33107

Merged
merged 1 commit into from Dec 29, 2017
Merged

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Dec 27, 2017

Motivation for this change

Fix #33078

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change
  • Tested execution of all binary files
  • Fits CONTRIBUTING.md.

ac_add_options --enable-jemalloc
ac_add_options --enable-shared-js
ac_add_options --enable-strip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be redundant, we strip in fixupPhase.

@lukateras
Copy link
Member

@GrahamcOfBorg build palemoon

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

Package ‘palemoon-27.6.2’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/applications/networking/browsers/palemoon/default.nix:95 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

patching script interpreter paths in /nix/store/d17a0vjrkzj3hn5wb27yl0w3z0b3r6fw-palemoon-27.6.2
/nix/store/d17a0vjrkzj3hn5wb27yl0w3z0b3r6fw-palemoon-27.6.2/lib/palemoon-27.6.2/run-mozilla.sh: interpreter directive changed from "/bin/sh" to "/nix/store/65l6hr8snf4v823f974k97jc65i7bhvf-bash-4.4-p12/bin/sh"
/nix/store/d17a0vjrkzj3hn5wb27yl0w3z0b3r6fw-palemoon-27.6.2/lib/palemoon-devel-27.6.2/sdk/bin/xpidl.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/hr461qqci171p6k53wwz52ifyp2h9g9l-python-2.7.14/bin/python"
/nix/store/d17a0vjrkzj3hn5wb27yl0w3z0b3r6fw-palemoon-27.6.2/lib/palemoon-devel-27.6.2/sdk/bin/xpt.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/hr461qqci171p6k53wwz52ifyp2h9g9l-python-2.7.14/bin/python"
/nix/store/d17a0vjrkzj3hn5wb27yl0w3z0b3r6fw-palemoon-27.6.2/lib/palemoon-devel-27.6.2/sdk/bin/nspr-config: interpreter directive changed from "/bin/sh" to "/nix/store/65l6hr8snf4v823f974k97jc65i7bhvf-bash-4.4-p12/bin/sh"
/nix/store/d17a0vjrkzj3hn5wb27yl0w3z0b3r6fw-palemoon-27.6.2/lib/palemoon-devel-27.6.2/sdk/bin/header.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/hr461qqci171p6k53wwz52ifyp2h9g9l-python-2.7.14/bin/python"
/nix/store/d17a0vjrkzj3hn5wb27yl0w3z0b3r6fw-palemoon-27.6.2/lib/palemoon-devel-27.6.2/sdk/bin/run-mozilla.sh: interpreter directive changed from "/bin/sh" to "/nix/store/65l6hr8snf4v823f974k97jc65i7bhvf-bash-4.4-p12/bin/sh"
/nix/store/d17a0vjrkzj3hn5wb27yl0w3z0b3r6fw-palemoon-27.6.2/lib/palemoon-devel-27.6.2/sdk/bin/typelib.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/hr461qqci171p6k53wwz52ifyp2h9g9l-python-2.7.14/bin/python"
checking for references to /tmp/nix-build-palemoon-27.6.2.drv-0 in /nix/store/d17a0vjrkzj3hn5wb27yl0w3z0b3r6fw-palemoon-27.6.2...
/nix/store/d17a0vjrkzj3hn5wb27yl0w3z0b3r6fw-palemoon-27.6.2

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: aarch64-linux

34:45.51 pkgdata: cd ../lib/ && rm -f libicudata.so && ln -s libicudata.so.58.2 libicudata.so
34:45.53 Note: rebuild with "/nix/store/4k5gmqlbmq776sp7p9n6irqa4bqibmar-gnumake-4.2.1/bin/make VERBOSE=1 all-local" to show all compiler parameters.
34:45.54 make[3]: *** [/build/palemoon-src/config/recurse.mk:37: compile] Error 2
34:45.54 make[2]: *** [/build/palemoon-src/config/rules.mk:541: default] Error 2
34:45.54 make[1]: *** [/build/palemoon-src/client.mk:399: realbuild] Error 2
34:45.54 make: *** [client.mk:171: build] Error 2
34:45.55 233 compiler warnings present.
34:45.67 Notification center failed: Install the python dbus module to get a notification when the build finishes.
builder for '/nix/store/mzrv9dpglx22qv0dak4hmfx9719k6yks-palemoon-27.6.2.drv' failed with exit code 2
error: build of '/nix/store/mzrv9dpglx22qv0dak4hmfx9719k6yks-palemoon-27.6.2.drv' failed

@lukateras
Copy link
Member

It seems that aarch64-linux has never had Pale Moon: http://archive.li/TDvuP

@lukateras lukateras merged commit 082416f into NixOS:master Dec 29, 2017
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Dec 29, 2017

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants