Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usbguard service: rules option should be of type 'lines' #33109

Merged
merged 1 commit into from Dec 29, 2017

Conversation

Nadrieril
Copy link
Member

@Nadrieril Nadrieril commented Dec 27, 2017

Motivation for this change

The services.usbguard.rules option expects a string comprized of lines. To make this option more usable, I changed the type of the option from str to lines. This does not break any existing config.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@globin globin merged commit 95fde40 into NixOS:master Dec 29, 2017
@Nadrieril Nadrieril deleted the usbguard-multiline-rules branch February 10, 2018 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants