mono: re-enable parallel building #32386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
This appears to have broken |
|
Sigh quite the drag. |
|
Fixed in 90bcfc7 |
thoughtpolice
added a commit
that referenced
this pull request
Dec 7, 2017
See #32386 -- while Mono in general should build correctly with parallel building, it seems the 4.4 branch has broken. Instead, allow parallel build support to be overridden by individual versions, and default to true. Signed-off-by: Austin Seipp <aseipp@pobox.com>
|
This probably needs some more work: |
|
Disabled for |
orivej
added a commit
that referenced
this pull request
Dec 9, 2017
|
Disabled |
|
:-) sounds like it should be disabled in generic mono expression and explicitly enabled in versions tested to be OK. |
|
If practically all of them are broken, we should just back out the change? |
copumpkin
pushed a commit
to copumpkin/nixpkgs
that referenced
this pull request
Jan 29, 2018
See NixOS#32386 -- while Mono in general should build correctly with parallel building, it seems the 4.4 branch has broken. Instead, allow parallel build support to be overridden by individual versions, and default to true. Signed-off-by: Austin Seipp <aseipp@pobox.com> (cherry picked from commit 90bcfc7)
copumpkin
pushed a commit
to copumpkin/nixpkgs
that referenced
this pull request
Jan 29, 2018
See NixOS#32386 mono46: https://hydra.nixos.org/build/65617511 mono48: https://hydra.nixos.org/build/65600645 (cherry picked from commit 0a41fc6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Shorter build times for mono packages. The commit that originally disabled parallel builds is from 2012 for an older version of mono and according to upstream the issues have been since resolved - https://bugzilla.xamarin.com/show_bug.cgi?id=2018.
/cc maintainers @viric @thoughtpolice @obadz @vrthra
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)