Move python pluggy to separate module #32391
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://hydra.nixos.org/build/65116569 It's x86-related booting stuff.
Add testing reqs, but keep tests disabled
Tests are runnable but still produce errors.
To get tests working, add locale setting, replace killall
and add nose package. To run the tests enable 'doCheck'.
Hunspell needs to be explicitly installed to use.
Patch SpellCheck.py to put hunspell in system datadir location.
For example, '/var/run/current-system/sw/share/hunspell/'
or '${HOME}/.nix-profile/share/hunspell/'
To get rid of atspi errors set
'services.gnome3.at-spi2-core.enable = true'
softhsm: darwin support
onboard: 1.4.1
i386-linux: broken aarch64-linux: x86_64-linux version is installed
fastlane: 2.66.2 -> 2.68.2
haskellPackages.tmp-postgres: Add pginit dependency
Also compile against latest boost.
Add pythonPackages.salmon and dependencies
This is required on the ThunderX CPUs on the Packet.net Type-2A machines that have a GICv3. For some reason the default is to create a GICv2 independent of the host hardware...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Pytest 3.3.x onward introduces new dependencies. One of them is pluggy. To make possible further changes easier it makes sense to extract it to a separate module.
I hope this is even the correct target branch for this change. I am sorry if not, please let me know and I'll change it as adviced.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/) (as pluggy is not an executable, I manually used a interactive python shell toimport pluggy.