build-support/vm: Use devtmpfs, not static device nodes #32390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 2017, there is no reason to create a static /dev.
|
I can't think of much else, no. The only reason I can think of for not doing it is that it could expose more impurities than the minimal set of device nodes we normally expose. Probably not a big deal though. |
|
Well, I expect the dynamic device node list to be a smaller pain, since you don't need to hunt down missing device nodes that applications assume are "always" there (like in 9f74cf3). And I don't need to figure out how to manually create the serial device node on AArch64 (which is |
|
Great, thanks 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2017, there is no reason to create a static /dev.
I have tested this with:
and
in Nix repository.
Do @edolstra and/or @copumpkin know anything else that might be using this?