Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tmux module: add secureSocket option #33165

Merged
merged 1 commit into from Dec 30, 2017
Merged

tmux module: add secureSocket option #33165

merged 1 commit into from Dec 30, 2017

Conversation

ghost
Copy link

@ghost ghost commented Dec 29, 2017 •
edited by ghost

Motivation for this change

Found that tmux sessions currently don't survive logouts (e.g. X11 restart) unlike on old NixOS releases (before 60025e3). So add an option so user will be able to revert this behaviour back.
/cc @peterhoeg

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@peterhoeg peterhoeg merged commit e56e156 into NixOS:master Dec 30, 2017
@ghost
Copy link
Author

ghost commented Dec 30, 2017

@peterhoeg Thanks!

@ghost ghost deleted the tmux branch December 30, 2017 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterhoeg @GrahamcOfBorg