Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xfce4-terminal: 0.6.3 -> 0.8.6 #33154

Closed
wants to merge 1 commit into from
Closed

xfce4-terminal: 0.6.3 -> 0.8.6 #33154

wants to merge 1 commit into from

Conversation

JohnAZoidberg
Copy link
Member

Motivation for this change

Upgrade package version - drops support for gtk2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@lukateras lukateras self-assigned this Dec 28, 2017
@lukateras lukateras added the 6.topic: xfce The Xfce Desktop Environment label Dec 28, 2017
@Mic92 Mic92 changed the title Upgrade xfce4-terminal to v0.8.6 xfce4-terminal: 0.6.3 -> 0.8.6 Dec 29, 2017
@lukateras
Copy link
Member

lukateras commented Dec 29, 2017 •
edited

Sorry, can't merge this precisely because they drop GTK+2. Xfce that is currently maintained in the tree corresponds to Xfce 4.12 branch, and xfce4-termianal 0.8 follows Xfce 4.13 branch.

There are some optionally available Xfce packages that use GTK+3, which is why there is libxfce4ui_gtk3, for example, but having them around will pose a problem with switching to new Xfce, and I'd rather not add to that problem.

Also mind that these GTK+3 packages are rarely used, because NixOS module services.xserver.desktopManager.xfce never pulls them in. One will likely have to setup an overlay or package override to use these packages.

Check out #32763, which also has xfce4-terminal 0.8.6. If you see any bugs in currently packaged xfce4-terminal, I will port fixes, just open an issue. I plan to commit complete Xfce 4.13 soon.

@lukateras lukateras closed this Dec 29, 2017
@Mic92 Mic92 mentioned this pull request Dec 29, 2017
Merged
8 tasks
@JohnAZoidberg JohnAZoidberg deleted the xfce4-terminal-0.8.6 branch October 30, 2018 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lukateras lukateras

Labels
6.topic: xfce The Xfce Desktop Environment 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JohnAZoidberg @lukateras @GrahamcOfBorg @Janik-Haag