fastpbkdf2: init at version 1.0.0 #33155

ledif · 2017-12-29T01:32:11Z

Motivation for this change

New package for fastpbkdf2, which is a fast PBKDF2-HMAC-{SHA1,SHA256,SHA512} implementation in C.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

lukateras · 2017-12-29T03:40:29Z

pkgs/development/libraries/fastpbkdf2/default.nix

+  meta = with stdenv.lib; {
+    description = "A fast PBKDF2-HMAC-{SHA1,SHA256,SHA512} implementation in C";
+    homepage = https://github.com/ctz/fastpbkdf2;
+    licenses = licenses.cc0;


Doesn't evaluate. It should be license = licenses.cc0;

lukateras · 2017-12-29T03:41:24Z

pkgs/development/libraries/fastpbkdf2/default.nix

+  name = "fastpbkdf2-1.0.0";
+
+  src = fetchurl {
+    url = https://github.com/ctz/fastpbkdf2/archive/v1.0.0.tar.gz;


This seems to be ref archive, these are not deterministic (because compression is not deterministic). Hash will change after a while. Use fetchFromGitHub instead.

lukateras · 2017-12-29T03:42:19Z

pkgs/development/libraries/fastpbkdf2/default.nix

+  buildInputs = [ openssl ];
+
+  preBuild = ''
+    makeFlagsArray=(CFLAGS="-std=c99 -O3 -g")


-O3 doesn't seem to be particularly safe for general use.

There are many packages that have -O3 in their CFLAGS, but I agree that it may not be portable across different platforms. Do you know of a more portable way to enable optimization in the build?

I couldn't find a better mechanism in Nixpkgs, so nevermind. I thought -O2 might be better, but on a general note it would be better if optimization flags were set somewhere else and not in the derivation.

lukateras · 2017-12-29T03:43:24Z

pkgs/development/libraries/fastpbkdf2/default.nix

+
+  installPhase = ''
+    mkdir -p $out/{lib,include/fastpbkdf2}
+    cp *.a $out/lib


Do they only ship static libraries? If there is some way to tweak build system to emit dynamic libraries (I think in case of macOS it's dylibs), it would be better.

This package only has a static library, and I do not know of a way to make it generate a shared library without patching the Makefile.

lukateras · 2017-12-29T03:44:55Z

@GrahamcOfBorg build fastpbkdf2

GrahamcOfBorg

Success for system: x86_64-darwin

ar: creating archive libfastpbkdf2.a
clang -std=c99 -O3 -g   -c -o bench.o bench.c
clang   bench.o fastpbkdf2.o  -lcrypto -o bench
clang -std=c99 -O3 -g   -c -o benchmulti.o benchmulti.c
clang   benchmulti.o fastpbkdf2.o  -lcrypto -o benchmulti
installing
post-installation fixup
stripping (with flags -S) in /nix/store/l9lmjv27hsbyd4cilb9fcgasmf0b10gb-fastpbkdf2-1.0.0/lib 
patching script interpreter paths in /nix/store/l9lmjv27hsbyd4cilb9fcgasmf0b10gb-fastpbkdf2-1.0.0
/nix/store/l9lmjv27hsbyd4cilb9fcgasmf0b10gb-fastpbkdf2-1.0.0

GrahamcOfBorg

Success for system: aarch64-linux

gcc   bench.o fastpbkdf2.o  -lcrypto -o bench
gcc -std=c99 -O3 -g   -c -o benchmulti.o benchmulti.c
gcc   benchmulti.o fastpbkdf2.o  -lcrypto -o benchmulti
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/vb5mpsfyph2slfsq8r5kknpphiqb3sy2-fastpbkdf2-1.0.0
stripping (with flags -S) in /nix/store/vb5mpsfyph2slfsq8r5kknpphiqb3sy2-fastpbkdf2-1.0.0/lib
patching script interpreter paths in /nix/store/vb5mpsfyph2slfsq8r5kknpphiqb3sy2-fastpbkdf2-1.0.0
checking for references to /build in /nix/store/vb5mpsfyph2slfsq8r5kknpphiqb3sy2-fastpbkdf2-1.0.0...
/nix/store/vb5mpsfyph2slfsq8r5kknpphiqb3sy2-fastpbkdf2-1.0.0

GrahamcOfBorg

Success for system: x86_64-linux

gcc   bench.o fastpbkdf2.o  -lcrypto -o bench
gcc -std=c99 -O3 -g   -c -o benchmulti.o benchmulti.c
gcc   benchmulti.o fastpbkdf2.o  -lcrypto -o benchmulti
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/76h51rrcqasg3cjxg9lafs745b92vfr7-fastpbkdf2-1.0.0
stripping (with flags -S) in /nix/store/76h51rrcqasg3cjxg9lafs745b92vfr7-fastpbkdf2-1.0.0/lib 
patching script interpreter paths in /nix/store/76h51rrcqasg3cjxg9lafs745b92vfr7-fastpbkdf2-1.0.0
checking for references to /tmp/nix-build-fastpbkdf2-1.0.0.drv-0 in /nix/store/76h51rrcqasg3cjxg9lafs745b92vfr7-fastpbkdf2-1.0.0...
/nix/store/76h51rrcqasg3cjxg9lafs745b92vfr7-fastpbkdf2-1.0.0

lukateras · 2017-12-30T02:23:41Z

@GrahamcOfBorg eval
@GrahamcOfBorg build fastpbkdf2

GrahamcOfBorg

Success for system: x86_64-darwin

ar: creating archive libfastpbkdf2.a
clang -std=c99 -O3 -g   -c -o bench.o bench.c
clang   bench.o fastpbkdf2.o  -lcrypto -o bench
clang -std=c99 -O3 -g   -c -o benchmulti.o benchmulti.c
clang   benchmulti.o fastpbkdf2.o  -lcrypto -o benchmulti
installing
post-installation fixup
stripping (with flags -S) in /nix/store/nbv2c5v8jdii9xrbc7jjxhjbrmxb9j9h-fastpbkdf2-1.0.0/lib 
patching script interpreter paths in /nix/store/nbv2c5v8jdii9xrbc7jjxhjbrmxb9j9h-fastpbkdf2-1.0.0
/nix/store/nbv2c5v8jdii9xrbc7jjxhjbrmxb9j9h-fastpbkdf2-1.0.0

GrahamcOfBorg

Success for system: aarch64-linux

gcc   bench.o fastpbkdf2.o  -lcrypto -o bench
gcc -std=c99 -O3 -g   -c -o benchmulti.o benchmulti.c
gcc   benchmulti.o fastpbkdf2.o  -lcrypto -o benchmulti
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ciwvibjpc1aq19g48wbb195ns4khqdqp-fastpbkdf2-1.0.0
stripping (with flags -S) in /nix/store/ciwvibjpc1aq19g48wbb195ns4khqdqp-fastpbkdf2-1.0.0/lib
patching script interpreter paths in /nix/store/ciwvibjpc1aq19g48wbb195ns4khqdqp-fastpbkdf2-1.0.0
checking for references to /build in /nix/store/ciwvibjpc1aq19g48wbb195ns4khqdqp-fastpbkdf2-1.0.0...
/nix/store/ciwvibjpc1aq19g48wbb195ns4khqdqp-fastpbkdf2-1.0.0

GrahamcOfBorg

Success for system: x86_64-linux

gcc   bench.o fastpbkdf2.o  -lcrypto -o bench
gcc -std=c99 -O3 -g   -c -o benchmulti.o benchmulti.c
gcc   benchmulti.o fastpbkdf2.o  -lcrypto -o benchmulti
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/1kbzhnzzf6wrh5zhxh6h9i6skzrfpj1s-fastpbkdf2-1.0.0
stripping (with flags -S) in /nix/store/1kbzhnzzf6wrh5zhxh6h9i6skzrfpj1s-fastpbkdf2-1.0.0/lib 
patching script interpreter paths in /nix/store/1kbzhnzzf6wrh5zhxh6h9i6skzrfpj1s-fastpbkdf2-1.0.0
checking for references to /tmp/nix-build-fastpbkdf2-1.0.0.drv-0 in /nix/store/1kbzhnzzf6wrh5zhxh6h9i6skzrfpj1s-fastpbkdf2-1.0.0...
/nix/store/1kbzhnzzf6wrh5zhxh6h9i6skzrfpj1s-fastpbkdf2-1.0.0

lukateras · 2017-12-30T02:26:23Z

Thank you!

ledif added 2 commits December 28, 2017 19:18

Add package fastpbkdf2

c2617b4

Add maintainer

0bc9890

lukateras reviewed Dec 29, 2017

View reviewed changes

lukateras requested changes Dec 29, 2017

View reviewed changes

GrahamcOfBorg reviewed Dec 29, 2017

View reviewed changes

Change fetchurl to fetchFromGitHub and update license

2ec2408

GrahamcOfBorg added 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Dec 29, 2017

lukateras approved these changes Dec 30, 2017

View reviewed changes

GrahamcOfBorg reviewed Dec 30, 2017

View reviewed changes

lukateras merged commit 6a6e34b into NixOS:master Dec 30, 2017

ledif deleted the fastpbkdf2 branch December 30, 2017 03:03

Janik-Haag added the 12. first-time contribution label Jun 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fastpbkdf2: init at version 1.0.0 #33155

fastpbkdf2: init at version 1.0.0 #33155

ledif commented Dec 29, 2017

lukateras Dec 29, 2017 •

edited

lukateras Dec 29, 2017

lukateras Dec 29, 2017

ledif Dec 29, 2017

lukateras Dec 30, 2017

lukateras Dec 29, 2017

ledif Dec 29, 2017

lukateras Dec 29, 2017

lukateras commented Dec 29, 2017

GrahamcOfBorg left a comment

GrahamcOfBorg left a comment

GrahamcOfBorg left a comment

lukateras commented Dec 30, 2017

GrahamcOfBorg left a comment

GrahamcOfBorg left a comment

GrahamcOfBorg left a comment

lukateras commented Dec 30, 2017

fastpbkdf2: init at version 1.0.0 #33155

fastpbkdf2: init at version 1.0.0 #33155

Conversation

ledif commented Dec 29, 2017

Motivation for this change

Things done

lukateras Dec 29, 2017 • edited

Choose a reason for hiding this comment

lukateras Dec 29, 2017

Choose a reason for hiding this comment

lukateras Dec 29, 2017

Choose a reason for hiding this comment

ledif Dec 29, 2017

Choose a reason for hiding this comment

lukateras Dec 30, 2017

Choose a reason for hiding this comment

lukateras Dec 29, 2017

Choose a reason for hiding this comment

ledif Dec 29, 2017

Choose a reason for hiding this comment

lukateras Dec 29, 2017

Choose a reason for hiding this comment

lukateras commented Dec 29, 2017

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

lukateras commented Dec 30, 2017

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

lukateras commented Dec 30, 2017

lukateras Dec 29, 2017 •

edited